Re: [matplotlib-devel] Last call for 1.2.0

[Michael D. <md...@st...>]

While I think Paul's contribution in #1462 is great, I'd prefer to not 
put this in 1.2.0.  There just isn't enough time to review such a large 
patch this late in the game.  As our experience with Nelle's valuable 
PEP8 work shows, it's still possible to slip in accidental breakage even 
when making mostly mechanical changes.  I'm fine with it going on the 
1.2.x branch after the release, however, so it would be in 1.2.1 (if we 
do one), so there's no need to change the PR target etc. at this point 
-- I'll just add a note that we don't want it to be merged until after 
1.2.0 has been tagged.

Mike

On 11/08/2012 05:38 AM, Phil Elson wrote:
> Just closed the PR which proposes this change against master (in 
> favour of the one against v1.2.x).
>
> It is very late in the day to be making so many example changes 
> (especially as we don't have tests for them).
> Personally, the balance between the risks vs the benefits doesn't give 
> me much indication of which way to go (I guess that is partly because 
> I don't actually prefer the plt.subplots() interface in some 
> situations). I guess that is a debate for inside the PR 
> (https://github.com/matplotlib/matplotlib/pull/1462).
>
> Cheers,
>
>
>
>
> On 8 November 2012 09:22, Paul Ivanov <piv...@gm... 
> <mailto:piv...@gm...>> wrote:
>
>     On Wed, Nov 7, 2012 at 6:23 PM, Michael Droettboom
>     <md...@st... <mailto:md...@st...>> wrote:
>     > The milestone is clear.  Is there anything we're missing?
>     >
>     > If not, I plan to cut a final release and update the documentation
>     > website tomorrow morning.
>
>     I just submitted #1462 against v1.2.x, (which is also pending as #1458
>     against master).
>
>     "use plt.subplots() in examples as much as possible"
>
>     replaces a whole bunch of example code like this:
>
>         fig = plt.figure()
>         ax = plt.subplot(111) # or plt.add_subplot(111)
>
>     to be just this:
>
>         fig, ax = plt.subplots()
>
>     This is a docs-only update - but I think it'll be worthwhile to start
>     to give a more sensible way of creating figures and axes in one call
>     for our the folks who'll be looking at matplotlib with fresh eyes
>     after the 1.2 release.
>
>     But I totally understand if folks feel this is too big of a pill to
>     swallow this late in the game.
>
>     go, team, go!
>     --
>     Paul Ivanov
>     314 address only used for lists,  off-list direct email at:
>     http://pirsquared.org | GPG/PGP key id: 0x0F3E28F7
>
>     ------------------------------------------------------------------------------
>     Everyone hates slow websites. So do we.
>     Make your web apps faster with AppDynamics
>     Download AppDynamics Lite for free today:
>     http://p.sf.net/sfu/appdyn_d2d_nov
>     _______________________________________________
>     Matplotlib-devel mailing list
>     Mat...@li...
>     <mailto:Mat...@li...>
>     https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
>
>
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel