Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

[Benjamin R. <ben...@ou...>]

On Monday, October 15, 2012, Nelle Varoquaux wrote:

>
>
> On 15 October 2012 04:49, Jae-Joon Lee <lee...@gm...<javascript:_e({}, 'cvml', 'lee...@gm...');>
> > wrote:
>
>> I'd agree with Eric on most of his points.
>>
>> On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing <ef...@ha...<javascript:_e({}, 'cvml', 'ef...@ha...');>>
>> wrote:
>> > If some of the PEP8 commits include genuine bug-fixes that need to be in
>> > v1.2.x, then these fixes should be made via PRs directly against v1.2.x.
>>
>> I think it is not a good idea to have a PR that mixes a bug-fix with a
>> PEP8 fix that is not related with the bug.
>> Maybe we need to ask for separate PRs, one for PEP8 fix and one for
>> bug-fixes.
>>
>
> I usually add a FIXME note in the code. I wouldn't rush those bug fixes,
> as they often have been there for a long time and corresponds to code that
> just would not run (hence, code that isn't tested).
>
>

Nelle, let me just take a moment to thank you for all the PEP8 work you
have done.  At first I was fine with these PRs being in v1.2.x, but now
that some ports are being removed, perhaps it is best for these to all go
into master.
>
>
Cheers!
Ben Root