Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

[Nelle V. <nel...@gm...>]

On 15 October 2012 04:49, Jae-Joon Lee <lee...@gm...> wrote:

> I'd agree with Eric on most of his points.
>
> On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing <ef...@ha...> wrote:
> > If some of the PEP8 commits include genuine bug-fixes that need to be in
> > v1.2.x, then these fixes should be made via PRs directly against v1.2.x.
>
> I think it is not a good idea to have a PR that mixes a bug-fix with a
> PEP8 fix that is not related with the bug.
> Maybe we need to ask for separate PRs, one for PEP8 fix and one for
> bug-fixes.
>

I usually add a FIXME note in the code. I wouldn't rush those bug fixes, as
they often have been there for a long time and corresponds to code that
just would not run (hence, code that isn't tested).


>
> Regards,
>
> -JJ
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>