From: Eric F. <ef...@ha...> - 2012-10-15 03:00:30
|
On 2012/10/14 4:49 PM, Jae-Joon Lee wrote: > I'd agree with Eric on most of his points. > > On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing <ef...@ha...> wrote: >> If some of the PEP8 commits include genuine bug-fixes that need to be in >> v1.2.x, then these fixes should be made via PRs directly against v1.2.x. > > I think it is not a good idea to have a PR that mixes a bug-fix with a > PEP8 fix that is not related with the bug. > Maybe we need to ask for separate PRs, one for PEP8 fix and one for bug-fixes. I think that has been the case; certainly it has been the general intention. I put in the remark you quoted in case there might have been one or two small exceptions. Eric > > Regards, > > -JJ > |