From: Jae-Joon L. <lee...@gm...> - 2012-10-15 02:49:51
|
I'd agree with Eric on most of his points. On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing <ef...@ha...> wrote: > If some of the PEP8 commits include genuine bug-fixes that need to be in > v1.2.x, then these fixes should be made via PRs directly against v1.2.x. I think it is not a good idea to have a PR that mixes a bug-fix with a PEP8 fix that is not related with the bug. Maybe we need to ask for separate PRs, one for PEP8 fix and one for bug-fixes. Regards, -JJ |