From: Ian T. <ian...@gm...> - 2012-09-21 07:27:13
|
On 20 September 2012 22:30, Damon McDougall <dam...@gm...>wrote: > I have been playing with custom triangulations in the plot_trisurf > method of the mplot3d toolkit. I thought I would share my sweet > creation: https://www.dropbox.com/s/ccptm6ok7nd3yn5/mobius.png > > Let me know your thoughts. I should probably make a pull request out > of this, but the code is not currently readable by humans. I will tidy > it up first. Make it look purrty. > Yes please! Ideally it would be good if all mplot3d functions supported the same arg and kwarg combinations as their 2d equivalents, for consistency. You may have done this already, but if not you might find the 2d tripcolor code helpful - it calls Triangulation.get_from_args_and_kwargs(*args, **kwargs) to do the initial heavy lifting. Forgive my cheek, but whilst you are looking at this area mplot3d.tricontour and tricontourf need similar improvement... A wider issue, and something I should have mentioned when you first implemented plot_trisurf, is that I don't like the function name. It seems unnecessary to have the plot_ at the front as most of the other plot-related functions manage without it. My unease extends to plot_surface and plot_wireframe as well. I guess we can't just change such names now that they are being used, but eventually I would like to see better naming within mplot3d. Thanks, Ian |