Re: [matplotlib-devel] Affine Transformations on images

[Michael D. <md...@st...>]

On 07/14/2011 07:33 AM, Martin Teichmann wrote:
> Hello List,
> Hello Michael, Hello Jae-Joon,
>
> Michale wrote:
>> It looks like overriding "draw_unsampled_image" is the wrong thing to do
>> here, though.
> JJ wrote:
>> Overriding this behavior (which I guess is the case of you current ShearImage
>> implementation. Please correct me if I'm wrong) won't be acceptable.
>
> I don't know where to go from here. We could:
>
> - make make_image actually draw the image. This would be a break in
> the API.
> - introduce a new method (_draw_sampled_image seems like a good name)
> that does that. That indirectly changes the API since make_image won't
> be called anymore, overriding it doesn't make a difference anymore.
I think either of these is ok.  make_image is not really in the public 
API anyway -- I know it doesn't have a preceding underscore, but I think 
this code may predate that convention.  If you add _draw_sampled_image, 
I would remove make_image to eliminate confusion.
> - Rewrite matplotlib from scratch in Java (just kidding)
We generally, consider patches in first-come-first-serve order, so I 
would recommend taking whichever approach could be completed sooner ;)

Cheers,
Mike

-- 
Michael Droettboom
Science Software Branch
Space Telescope Science Institute
Baltimore, Maryland, USA