From: Andrew S. <str...@as...> - 2010-07-23 15:31:19
|
On 7/23/10 3:16 PM, Michael Droettboom wrote: > I've traced this back to revision 7867: > > http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/branches/v0_99_maint/lib/matplotlib/axes.py?r1=7867&r2=7866&pathrev=7867 > <http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/branches/v0_99_maint/lib/matplotlib/axes.py?r1=7867&r2=7866&pathrev=7867> > > Andrew: I'm sure that change is there for a good reason -- do you > remember what it was? I don't just want to revert it. Interestingly, > get_clip_on() is True by default, and I'm not sure in what case it's > set to False in this context. Hi Mike, I don't remember this. But looking back at the commit logs, I see "imshow: only apply axes patch clipping if image doesn't clip itself" as the original commit message and then a few minutes later I committed the test test_imshow_clip() in text_axes.py. It looks like I was responding to a bug and/or patch submission. As long as that test still passes, I think it's OK to check in your fix. We could also add Tobias' script as another test. -Andrew |