From: Reinier H. <re...@he...> - 2009-03-18 23:03:08
|
Hi all, I reworked the code in axis3d so that the XYZ-planes are always behind the object you're plotting. I also updated the label/ticks drawing a bit and dropped a lot of unnecessary code. I pushed it to my git repo at http://qtwork.nano.tudelft.nl/cgi-bin/gitweb.cgi?p=users/rwh/mplot3d;a=summary Regards, Reinier On Wed, Mar 11, 2009 at 11:22 PM, Reinier Heeres <re...@he...> wrote: > Hi Jon, > > Good point, I forgot about that! > > It's available for cloning now: git clone > http://qtwork.nano.tudelft.nl/public_git/users/rwh/mplot3d > > Cheers, > Reinier > > On Wed, Mar 11, 2009 at 6:43 PM, Jonathan Taylor > <jon...@ut...> wrote: >> Hi, that is great! Can you give me a git repository address to pull >> from? I can't from the web viewer. >> >> Thanks, >> J. >> >> On Wed, Mar 11, 2009 at 4:25 AM, Reinier Heeres <re...@he...> wrote: >>> Hi, >>> >>> I updated my patch a bit more, and now all tests are running (try >>> "python axes3d.py"). Only the contourf3D is not working correctly yet, >>> but I'm sure it's fixable soon. There are also some obvious bugs (e.g. >>> the semi-3D histograms are not depth-sorted). >>> >>> Anyway, I have applied the commit in a different git repo that also >>> has gitweb.cgi for viewing: >>> http://qtwork.nano.tudelft.nl/cgi-bin/gitweb.cgi?p=users/rwh/mplot3d;a=summary >>> >>> Jon, I got rid of the spurious commit-and-revert entries but included >>> your latest commits; perhaps you can clone from this tree now? >>> >>> Although I've not had a close look at the BSD license it definitely >>> sounds like a good idea to add it if it applies to the original code. >>> Shall we try to work to some sort of easily-installable form of the >>> again-working code? >>> >>> Regards, >>> Reinier >>> >>> On Mon, Mar 9, 2009 at 3:45 AM, Jonathan Taylor >>> <jon...@ut...> wrote: >>>> Hi Reinier, >>>> >>>> Awesome. Those plots are making me smile! I also agree with your >>>> refactoring and have applied your patch to my git repository. >>>> >>>> I agree with you concerning the sympy plotting routines. I think what >>>> we have here is quite flexible and does a very good job of replicating >>>> the equivalent functionality of MATLAB. I think it would be a huge >>>> effort trying to make 2D plots and 3D plots look consistent if another >>>> approach was taken. Indeed, this is a desirable characteristic. In >>>> addition, the code is actually very short and easy to maintain. Given >>>> that matplotlib has had trouble maintaining 3D code in the past, it >>>> might not be a good idea to switch to a more complicated codebase. >>>> >>>> You should grab some of my more recent changes as I have added a few >>>> more fixes. Most importantly, if you reuse the same figure, the old >>>> event handlers will still attached preventing Axes objects from dieing >>>> and causing interactive manipulation of the plots to be very sluggish. >>>> Also, in terms of performance, I have found that switching to TkAgg >>>> from GTKAgg was helpful. >>>> >>>> Also, I think the original code from John Porter was under a BSD >>>> license. I am thinking of adding our names and the BSD license to the >>>> top of each file to protect it while its not officially part of >>>> matplotlib. What do you think? >>>> >>>> Best, >>>> Jonathan. >>> >>> -- >>> Reinier Heeres > > -- > Reinier Heeres -- Reinier Heeres Waalstraat 17 2515 XK Den Haag The Netherlands Tel: +31 6 10852639 |