From: Andrew S. <str...@as...> - 2008-12-01 20:03:34
|
John Hunter wrote: > On Sun, Nov 30, 2008 at 11:53 AM, Jae-Joon Lee <lee...@gm...> wrote: > > >> I have been working on reimplementation of the legend class, and I >> guess it is mostly done. The biggest change is how each items are >> placed. For this, I made a simple container class("offsetbox.py"), >> which can pack the mpl artists in a similar way as widget packing in >> gtk, tk, etc. >> > > Hi Jae-Joon -- as usual this is great work, and brings one of the > oldest, hairiest, parts of the code into the modern age. I went ahead > and committed this to svn r6461 with some minor spelling corrections, > but I have some minor comments below which may be worth addressing in > a revision. > > Aside from the legend enhancement, the important and general piece > here is the offset box, which could become a significant piece of the > low-level infrastructure (eg for axes layout) so I do want to make > sure we get this right. In particular, I'd like Andrew Straw, who has > a toolkit for sizers, and Michael Droettboom, who implemented the > Knuth boxes in support of mathtext, to take a look at the API and > provide some feedback as to whether if it looks sufficient. > Hi Jae-Joon and John, The MPL sizer toolkits looks entirely unaffected by these changes, and the demo looks very convincing. So from my perspective this would be a benefit to have in assuming that the issues John raises can be dealt with. |