Re: [matplotlib-devel] annotation with fancy arrow

[Darren D. <dar...@co...>]

Line 2900 in patches.py is not compatible with python-2.6. "as" is protected 
and cannot be used as a variable name.

On Thursday 30 October 2008 09:49:24 am John Hunter wrote:
> On Thu, Oct 30, 2008 at 12:32 AM, Jae-Joon Lee <lee...@gm...> wrote:
> > John and others,
> >
> > I submitted a patch of the fancy arrow I mentioned a while ago.
> >
> > http://sourceforge.net/tracker2/?func=detail&aid=2209021&group_id=80706&a
> >tid=560722
>
> Hi Jae Joon -- sorry for not responding.  I had completely missed
> this.  Reminding us on the mailing list is definitely a good idea
> because I tend to fall behind quite often.
>
> The patch and new example look great.  My only requests for changes
> (or for next time) are stylistic:
>
>   - when making a significant contribution like this, please add a
> change to the CHANGELOG, since that is what many people use to see
> what's new and what we use to make the release notes.  I've done this
> already for this one.
>
>   - try and document every method using the rest documentation
> conventions.  See
> http://matplotlib.sourceforge.net/devel/documenting_mpl.html.  Since
> we have been working hard on the website and API docs, the one thing
> I'd like to ask of you is to make sure all the docstrings are updated
> including a bit of module level documentation in bezier -- then I will
> add bezier to the API docs
>
>
>   - for triple quoted docstrings, I would like to stick to the format::
>
>     def myfunc(args):
>         """"
>         this is my docstring
>         """"
>
>    rather than
>
>
>     def myfunc(args):
>         """"this is my docstring
>         """"
>
>   - I renamed bezier_util to bezier (PEP8 style guide advises to avoid
> underscores and make module names as short as is reasonable), and we
> should import it with the full name "from matplotlib.bezier import
> ..." rather than "from bezier import ..."
>
>   - is using a string for connectionstyle the best choice?  Ie, instead
> of::
>
>       connectionstyle="angle,angleA=0,angleB=90,rad=10"
>
>     would we rather have something like::
>
>       connectionstyle=connectionstyle.angle(angleA=0,angleB=90,rad=10)
>
>     The latter looks more pythonthic and extensible, because if we document
> the connectionstyle API users can provide their own.
>
> These are of course mostly minor stylistic nits, but I want the code
> to be as uniform as possible.
>
> I've committed this to svn r6353, and updated the website, so you can
> see your examples in the gallery and examples pages:
>
>   http://matplotlib.sourceforge.net/gallery.html
>   http://matplotlib.sourceforge.net/gallery.html
>
> Very nice contribution!
> JDH
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge Build the coolest Linux based applications with Moblin SDK & win
> great prizes Grand prize is a trip for two to an Open Source event anywhere
> in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

-- 
Darren S. Dale, Ph.D.
Staff Scientist
Cornell High Energy Synchrotron Source
Cornell University
275 Wilson Lab
Rt. 366 & Pine Tree Road
Ithaca, NY 14853

dar...@co...
office: (607) 255-3819
fax: (607) 255-9001
http://www.chess.cornell.edu