From: Paul K. <pki...@gm...> - 2008-07-28 07:42:31
|
On Sun, Jul 27, 2008 at 9:54 PM, John Hunter <jd...@gm...> wrote: > On Sun, Jul 27, 2008 at 4:57 PM, Paul Kienzle <pki...@gm...> wrote: > >> My inclination is to avoid diamond inheritance in this case by >> moving the wx base class to wxagg. Let me know and I will >> implement it. > > My weak preference would be to do this as a mixin factorint out the > renderer from the GUI stuff. If this is only marginally harder, it > makes it easier down the road if someone wants to mixin a different > renderer from agg, or if the wx renderer ever improces sufficiently to > make it usable. But if this seems like a lot more work, I am not > averse to simply deprecating the wx renderer, though factoring > everything to make mixing in a different renderer later will still be > useful. In the end, whatever you decide will be fine. I won't be able to spend time on this short term --- it took me too long to sort out containment and drawing. >> There is one more outstanding change to wx before I can stop >> subclassing the WxAgg canvas in my own applications, which is >> that draw is being called too often. Putting a print statement in >> WxAgg draw and _onPaint I get the following: > > OK, now that we have missed the debian freeze, the pressure to get > something out sooner is lessened, do we'll just work on getting it > right. I hope that wasn't on account of wx. These were not show-stopper issues. Since we are not under pressure, I committed another set of changes to Wx+WxAgg. Now they should only render the graph when the window is shown. I would appreciate having windows and linux users beat on it for a while, in particular testing lasso_demo before and after printing. I'm also attaching embedding_in_wx5.py, which puts a pair of graphs into a wx notebook. - Paul |