SF.net SVN: matplotlib:[5785] trunk/matplotlib

[<jd...@us...>]

Revision: 5785
          http://matplotlib.svn.sourceforge.net/matplotlib/?rev=5785&view=rev
Author:   jdh2358
Date:     2008-07-17 21:06:17 +0000 (Thu, 17 Jul 2008)

Log Message:
-----------
removed screen noise comments from gtkagg and image since I no longer consider this to be a bug

Modified Paths:
--------------
    trunk/matplotlib/lib/matplotlib/backends/backend_gtkagg.py
    trunk/matplotlib/src/_image.cpp

Modified: trunk/matplotlib/lib/matplotlib/backends/backend_gtkagg.py
===================================================================
--- trunk/matplotlib/lib/matplotlib/backends/backend_gtkagg.py	2008-07-17 20:51:38 UTC (rev 5784)
+++ trunk/matplotlib/lib/matplotlib/backends/backend_gtkagg.py	2008-07-17 21:06:17 UTC (rev 5785)
@@ -81,13 +81,6 @@
         w = int(ren.width)
         h = int(ren.height)
 
-        # There apparently is a bug here on some versions of pygtk
-        # (2.6) that crops up in corner cases.  Eg, in
-        # figimage_demo.py, there is background pixel noise because
-        # the figure frame is off and the blended image background has
-        # alpha 0. and you see the uninitialzed data ("screen noise").
-        # If in _image.cpp Image:from_image you fill the background
-        # with a non transparent value, it goes away.
         pixbuf = gtk.gdk.pixbuf_new_from_data(
             buf, gtk.gdk.COLORSPACE_RGB,  True, 8, w, h, w*4)
         pixmap.draw_pixbuf(pixmap.new_gc(), pixbuf, 0, 0, 0, 0, w, h,

Modified: trunk/matplotlib/src/_image.cpp
===================================================================
--- trunk/matplotlib/src/_image.cpp	2008-07-17 20:51:38 UTC (rev 5784)
+++ trunk/matplotlib/src/_image.cpp	2008-07-17 21:06:17 UTC (rev 5785)
@@ -743,9 +743,6 @@
   renderer_base rb(pixf);
 
 
-  //clear the background of the rendering buffer with alpha 1 and the
-  //gtkagg screen noise problem in figimage_demo.py goes away -- see
-  //comment backend_gtkagg.py _render_figure method JDH
   rb.clear(agg::rgba(1, 1, 1, 1));
 
   for (size_t imnum=0; imnum< N; imnum++) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.