matplotlib-devel

[matplotlib-devel] test_axes:test_bxp_custombox baseline image wrong?

[Lennart F. <le...@di...>]

Hello, 

could somebody please check if the baseline_image is like it should be.
During refactoring some of the linestyle handling, the test mentioned
fails.
And it seems to me, that the expected image is not correct.

Best regards
Lennart

[matplotlib-devel] test_axes:test_bxp_custombox baseline image wrong?

[Lennart F. <le...@di...>]

Hello, 

could somebody please check if the baseline_image is like it should be.
During refactoring some of the linestyle handling, the test mentioned
fails.
And it seems to me, that the expected image is not correct.

Best regards
Lennart

Re: [matplotlib-devel] test_axes:test_bxp_custombox baseline image wrong?

[Paul H. <pmh...@gm...>]

I'll look into this now.


On Tue, Jul 15, 2014 at 11:43 AM, Lennart Fricke <le...@di...>
wrote:

>
> Hello,
>
> could somebody please check if the baseline_image is like it should be.
> During refactoring some of the linestyle handling, the test mentioned
> fails.
> And it seems to me, that the expected image is not correct.
>
> Best regards
> Lennart
>
>
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>

Re: [matplotlib-devel] test_axes:test_bxp_custombox baseline image wrong?

[Lennart F. <le...@di...>]

Hello Paul Hobson,

you changed defaults in:

commit 7df0313b010d211997cf391d1bee38e194db5618
Author: Paul Hobson <pmh...@gm...>
Date:   Wed May 14 00:01:57 2014 -0700

    restored default boxplot style and respect for the sym kwa

since then the plots look like they do now.
Maybe we should change the baseline images.

Best regards
Lennart

Re: [matplotlib-devel] test_axes:test_bxp_custombox baseline image wrong?

[Paul H. <pmh...@gm...>]

The defaults got reverted, but the baseline images did not.

Here's a branch with (un-?)updated baseline images:
https://github.com/phobson/matplotlib/commit/8b719e7bda4cef254fbe515e5dfc23d88f3ff5da

I based it off of master, should probably pull them into the 1.4.x branch
before submitting the PR.
-p


On Tue, Jul 15, 2014 at 11:28 PM, Lennart Fricke <le...@di...>
wrote:

> Hello Paul Hobson,
>
> you changed defaults in:
>
> commit 7df0313b010d211997cf391d1bee38e194db5618
> Author: Paul Hobson <pmh...@gm...>
> Date:   Wed May 14 00:01:57 2014 -0700
>
>     restored default boxplot style and respect for the sym kwa
>
> since then the plots look like they do now.
> Maybe we should change the baseline images.
>
> Best regards
> Lennart
>
>