matplotlib-devel — matplotlib developers

Re: [matplotlib-devel] New plot type idea -- EventRaster

[Damon M. <dam...@gm...>]

On Mon, Nov 12, 2012 at 2:17 PM, Paul Ivanov <piv...@gm...> wrote:
> On Mon, Nov 12, 2012 at 7:36 AM, Michael Droettboom <md...@st...> wrote:
>> On 11/11/2012 11:51 PM, Todd wrote:
>>> Now that 1.2 is out, can we revisit this?  I would like to get it
>>> implemented for the next feature release.
>>>
>>
>> Absolutely.  I think the next step, once you have an implementation,
>> would be to submit a pull request and we can all help with a review.
>
> This hasn't been mentioned yet, but Todd will hopefully find our
> developer docs useful:
> http://matplotlib.org/devel/index.html
>
> In particular, there's a section on writing a new pyplot function:
> http://matplotlib.org/devel/coding_guide.html#writing-a-new-pyplot-function

Thanks for that, Paul.

Todd, there's also a section on writing tests for matplotlib on the
page Paul pointed out. For a new feature there should be a couple of
tests to go with it to make sure everything passes sanity checks.

Thanks for spending your time contributing!

-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

Re: [matplotlib-devel] master vs maintenance branches (current process and proposal for future workflow)

[Damon M. <dam...@gm...>]

On Mon, Nov 12, 2012 at 2:52 PM, Benjamin Root <ben...@ou...> wrote:
>
>
> On Mon, Nov 12, 2012 at 3:44 PM, Paul Ivanov <piv...@gm...> wrote:
>>
>> Hey everyone,
>>
>> So I don't have a clear picture in my head of our development cycle, and I
>> don't think it's well documented. I didn't want thread jack, but in another
>> thread Mike wrote:
>>
>> On Mon, Nov 12, 2012 at 7:36 AM, Michael Droettboom <md...@st...>
>> wrote:
>> > (BTW -- feel free to submit pull requests at any point in a release
>> > cycle -- we have both a master and a maintenance branch, so we can work
>> > on new stuff and stable stuff at the same time).
>>
>> My first question is, how are these two branches related, because I've
>> been submitting things against master, and then switching it to be against
>> 1.2.x when I was asked. From what I have gathered, 1.2.x is for bugfixes,
>> and master is for new features.
>>
>
> That is correct.
>
>>
>> Can someone clarify the current process, with a section like "Submitting
>> new Pull Requests" -  this should probably go into one of these places:
>> http://matplotlib.org/devel/coding_guide.html
>> http://matplotlib.org/devel/gitwash/index.html
>>
>
> This is the essence of the gitwash process.  Perhaps it needs to be clearer.
>
>>
>> My second question is that, if I do have the right idea about the current
>> process, and the distinction between master and 1.2.x, should we change
>> this? (I think we should).
>>
>> The trouble is that it seems to me now for a bugfix, if it is submitted
>> against 1.2.x, it won't be fixed in master until changes from 1.2.x are
>> merged back into master. So now as a developer trying to follow "bleeding
>> edge" matplotlib, I either have to live with bugs that have been fixed in
>> 1.2.x if I want the features from master, or if I want the bug fixes and
>> follow 1.2.x, I miss the new features in master.
>>
>
> A general rule is that whoever merges a bugfix to the maintenance branch
> should then also manually merge the maintenance branch down to master.
>
>>
>> I think that the mental picture is sufficiently clearer if *everything*
>> (bugfixes and new features) go into master, and then we backport the
>> critical bugfixes against 1.2.x. This would be easier to do if the core
>> developer merging the bugfix into master at least opens an issue for as a
>> placeholder / reminder for the bugfix being a candidate to go into the
>> maintenance branch. Because it seems like at this point, we aren't even sure
>> if we're going to do a 1.2.1 release...
>>
>
> There are other git workflows, which are all perfectly valid.  If you can
> convince us to use another, feel free to propose one.  However, we have done
> a couple of releases with gitwash, and it has worked quite well for us given
> how small our maintenance overhead is.  Just have to remember to regularly
> merge the maintenance branch to master.  That's all.

Personally, I use this one:
http://nvie.com/posts/a-successful-git-branching-model/

It does involve a little more effort, it does also mean that someone
installing from the master branch (which is the default branch) will
always get a stable release. My feeling is that the master branch
shouldn't contain any unstable code. Also, it means that the user can
just clone the git repository without having floating tarballs all
over their home directory.

I'm not necessarily proposing we should change it, I just wanted to
point out a different approach. The git branching workflow we use for
matplotlib is perfectly valid and I'm happy using it.

-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Damon M. <dam...@gm...>]

On Mon, Nov 12, 2012 at 10:52 AM, Fernando Perez <fpe...@gm...> wrote:
> Hi folks,
>
> On Sun, Nov 11, 2012 at 1:20 PM, Damon McDougall
> <dam...@gm...> wrote:
>> Yeah that's a great idea. Get the word out.
>
> I did:
>
> https://speakerdeck.com/fperez/science-and-python-a-interactively-biased-retrospective-of-a-mostly-successful-decade?slide=17
>
> and the crowd actually erupted into spontaneous applause when I
> pointed out the py3 support!

That's what I like to hear. I played no part in the py3 support, but
it's a pretty herculean effort. In general I feel the 1.2.0 release is
an extremely robust release.

> So good job to the whole team.
>
> I also put in a slide about John pointing people to the memorial fund:
>
> https://speakerdeck.com/fperez/science-and-python-a-interactively-biased-retrospective-of-a-mostly-successful-decade?slide=50

Thanks Fernando.

-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

Re: [matplotlib-devel] master vs maintenance branches (current process and proposal for future workflow)

[Benjamin R. <ben...@ou...>]

On Mon, Nov 12, 2012 at 3:44 PM, Paul Ivanov <piv...@gm...> wrote:

> Hey everyone,
>
> So I don't have a clear picture in my head of our development cycle, and I
> don't think it's well documented. I didn't want thread jack, but in another
> thread Mike wrote:
>
> On Mon, Nov 12, 2012 at 7:36 AM, Michael Droettboom <md...@st...>
> wrote:
> > (BTW -- feel free to submit pull requests at any point in a release
> > cycle -- we have both a master and a maintenance branch, so we can work
> > on new stuff and stable stuff at the same time).
>
> My first question is, how are these two branches related, because I've
> been submitting things against master, and then switching it to be against
> 1.2.x when I was asked. From what I have gathered, 1.2.x is for bugfixes,
> and master is for new features.
>
>
That is correct.


> Can someone clarify the current process, with a section like "Submitting
> new Pull Requests" -  this should probably go into one of these places:
> http://matplotlib.org/devel/coding_guide.html
> http://matplotlib.org/devel/gitwash/index.html
>
>
This is the essence of the gitwash process.  Perhaps it needs to be clearer.


> My second question is that, if I do have the right idea about the current
> process, and the distinction between master and 1.2.x, should we change
> this? (I think we should).
>
> The trouble is that it seems to me now for a bugfix, if it is submitted
> against 1.2.x, it won't be fixed in master until changes from 1.2.x are
> merged back into master. So now as a developer trying to follow "bleeding
> edge" matplotlib, I either have to live with bugs that have been fixed in
> 1.2.x if I want the features from master, or if I want the bug fixes and
> follow 1.2.x, I miss the new features in master.
>
>
A general rule is that whoever merges a bugfix to the maintenance branch
should then also manually merge the maintenance branch down to master.


> I think that the mental picture is sufficiently clearer if *everything*
> (bugfixes and new features) go into master, and then we backport the
> critical bugfixes against 1.2.x. This would be easier to do if the core
> developer merging the bugfix into master at least opens an issue for as a
> placeholder / reminder for the bugfix being a candidate to go into
> the maintenance branch. Because it seems like at this point, we aren't even
> sure if we're going to do a 1.2.1 release...
>
>
There are other git workflows, which are all perfectly valid.  If you can
convince us to use another, feel free to propose one.  However, we have
done a couple of releases with gitwash, and it has worked quite well for us
given how small our maintenance overhead is.  Just have to remember to
regularly merge the maintenance branch to master.  That's all.

Cheers!
Ben Root

[matplotlib-devel] master vs maintenance branches (current process and proposal for future workflow)

[Paul I. <piv...@gm...>]

Hey everyone,

So I don't have a clear picture in my head of our development cycle, and I
don't think it's well documented. I didn't want thread jack, but in another
thread Mike wrote:

On Mon, Nov 12, 2012 at 7:36 AM, Michael Droettboom <md...@st...> wrote:
> (BTW -- feel free to submit pull requests at any point in a release
> cycle -- we have both a master and a maintenance branch, so we can work
> on new stuff and stable stuff at the same time).

My first question is, how are these two branches related, because I've been
submitting things against master, and then switching it to be against 1.2.x
when I was asked. From what I have gathered, 1.2.x is for bugfixes, and
master is for new features.

Can someone clarify the current process, with a section like "Submitting
new Pull Requests" -  this should probably go into one of these places:
http://matplotlib.org/devel/coding_guide.html
http://matplotlib.org/devel/gitwash/index.html

My second question is that, if I do have the right idea about the current
process, and the distinction between master and 1.2.x, should we change
this? (I think we should).

The trouble is that it seems to me now for a bugfix, if it is submitted
against 1.2.x, it won't be fixed in master until changes from 1.2.x are
merged back into master. So now as a developer trying to follow "bleeding
edge" matplotlib, I either have to live with bugs that have been fixed in
1.2.x if I want the features from master, or if I want the bug fixes and
follow 1.2.x, I miss the new features in master.

I think that the mental picture is sufficiently clearer if *everything*
(bugfixes and new features) go into master, and then we backport the
critical bugfixes against 1.2.x. This would be easier to do if the core
developer merging the bugfix into master at least opens an issue for as a
placeholder / reminder for the bugfix being a candidate to go into
the maintenance branch. Because it seems like at this point, we aren't even
sure if we're going to do a 1.2.1 release...


better,
-- 
Paul Ivanov
314 address only used for lists,  off-list direct email at:
http://pirsquared.org | GPG/PGP key id: 0x0F3E28F7

Re: [matplotlib-devel] New plot type idea -- EventRaster

[Paul I. <piv...@gm...>]

On Mon, Nov 12, 2012 at 7:36 AM, Michael Droettboom <md...@st...> wrote:
> On 11/11/2012 11:51 PM, Todd wrote:
>> Now that 1.2 is out, can we revisit this?  I would like to get it
>> implemented for the next feature release.
>>
>
> Absolutely.  I think the next step, once you have an implementation,
> would be to submit a pull request and we can all help with a review.

This hasn't been mentioned yet, but Todd will hopefully find our
developer docs useful:
http://matplotlib.org/devel/index.html

In particular, there's a section on writing a new pyplot function:
http://matplotlib.org/devel/coding_guide.html#writing-a-new-pyplot-function

-- 
Paul Ivanov
314 address only used for lists,  off-list direct email at:
http://pirsquared.org | GPG/PGP key id: 0x0F3E28F7

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Fernando P. <fpe...@gm...>]

Hi folks,

On Sun, Nov 11, 2012 at 1:20 PM, Damon McDougall
<dam...@gm...> wrote:
> Yeah that's a great idea. Get the word out.

I did:

https://speakerdeck.com/fperez/science-and-python-a-interactively-biased-retrospective-of-a-mostly-successful-decade?slide=17

and the crowd actually erupted into spontaneous applause when I
pointed out the py3 support!

So good job to the whole team.

I also put in a slide about John pointing people to the memorial fund:

https://speakerdeck.com/fperez/science-and-python-a-interactively-biased-retrospective-of-a-mostly-successful-decade?slide=50

Cheers,

f

Re: [matplotlib-devel] New plot type idea -- EventRaster

[Michael D. <md...@st...>]

On 11/11/2012 11:51 PM, Todd wrote:
> On Thu, Sep 27, 2012 at 8:18 PM, Todd <tod...@gm...> wrote:
>> On Thu, Sep 27, 2012 at 1:44 PM, Todd <tod...@gm...> wrote:
>>> On Thu, Sep 27, 2012 at 1:12 PM, Damon McDougall
>>> <dam...@gm...> wrote:
>>>> Hi Todd,
>>>>
>>>> Firstly, thanks for taking the time to crystallise your thoughts in
>>>> words first. This is one of my bad habits; I tend to rush into things.
>>>>
>>>> I have some feedback for you, hopefully we can all work together to
>>>> get this right. It's difficult when something new gets implemented and
>>>> someone expects it to do something and the only way to resolve it is
>>>> to break the calling API.
>>> Where is API broken?
>>>
>>>> Anyway, I hope you'll find my comments
>>>> helpful at the least. I also encourage others to weigh in with
>>>> opinions and ideas.
>>> Okay, I will discuss the rationale.  I will snip out anything you
>>> agree on for brevity.
>>>
>>>>> Assuming we go with the name, here is my proposed call signature:
>>>>>
>>>>> EventRaster(x, offset=0, height=1, **kargs)
>>>> CamelCase is discouraged for method names. Perhaps 'eventraster'?
>>> Fair enough.
>>>
>>>> Also, we could also let **kwargs swallow the 'offset' and 'height'
>>>> keyword arguments. Then the user isn't constrained by which order to
>>>> put them in. The downside of this approach is that introspection is
>>>> more difficult.
>>> I don't understand the advantage of this approach.  If you use keyword
>>> arguments, then the order doesn't matter.  So with the approach above
>>> you can use keyword arguments, in which case you can use whatever
>>> order they want, or you can use positional arguments.  On the other
>>> hand putting it in **kwargs, we lose the ability to use positional
>>> arguments.  So we lose nothing by allowing both positional and keyword
>>> arguments.  It is also easier to implement.
>>>
>>>>> offset determines the positions of the rows.  By default, the first
>>>>> row is placed with the line center y=0, and subsequent rows are placed
>>>>> with the line centers at increasing 1-unit increments.  If offset is
>>>>> defined and is a scalar, the first row is placed at the offset, and
>>>>> subsequent rows are placed at increasing 1-unit increments.  If offset
>>>>> is an array, it must be a 1D array of the same length as the second
>>>>> dimension of x.  In this case each element in offset determines the
>>>>> center of the corresponding row in the plot.
>>>> How about letting offset be either: a) a scalar, determining the
>>>> offset of all rows equally; or b) an array, determining the offset of
>>>> each row individually.
>>> Because people are almost never going to want to have all the lines
>>> stacked right on top of each other.  The plot would be indecipherable
>>> that way.  The defaults are chosen to handle the most common use-cases
>>> most easily.
>>>
>>>> In fact, why plot each row at integer y
>>>> coordinates? Could we allow for an optional y-coordinate array, each
>>>> element of which would be the y-coordinate at which to plot a row of
>>>> lines. Then you wouldn't need offset.
>>> That is exactly what offset does if you pass an array.
>>>
>>>>> If this is going to be used to implement rug plots, it would need some
>>>>> way to handle columns of horizontal lines in addition to rows of
>>>>> vertical lines.  I see two ways to implement this.  First is to have
>>>>> to plot types, perhaps HEventRaster and VEventRaster.  The first would
>>>>> be as described above, while the second would be similar but
>>>>> everything rotated 90 degrees.  Another possibility is to change the
>>>>> call signature to this:
>>>>>
>>>>> EventRaster(x, y=None, offset=0, height=1, **kargs)
>>>> I think accepting an 'orientation' kwarg, which can take either
>>>> 'horizontal' or 'vertical', determining the orientation of the lines
>>>> and reversing the roles of the x and y arrays.
>>> That would work as well.  Probably cleaner that way
>>>
>>>>> The function will return a list of a new collection type I am
>>>>> tentatively calling EventCollection.  My thinking would be this would
>>>>> be a subclass of a new collection type called GenericLineCollection,
>>>>> which the current LineCollection would also subclass.  They would
>>>>> share things like the color handling and segment handling, however the
>>>>> segment handling will be a "private" method that LineCollection will
>>>>> have a public wrapper for.  On the other hand methods to set or add
>>>>> segments will remain private in EventCollection, although there will
>>>>> be a method to return the segments if an artist really wants to
>>>>> manipulate individual segments.
>>>> Why can't we just use LineCollection? I don't see a good reason to
>>>> create a new collection class here; the plot is simple.
>>> Explained below.
>>>
>>>>> The reason for doing it this way is that manipulating individual rows
>>>>> of events should be very common, such as changing their position,
>>>>> color, marker, width, and so on.  On the other hand manipulating lines
>>>>> individually should not be as common, although still supported.
>>>> Fair enough, then maybe a better idea is to create your own
>>>> EventRaster class (note camel case) to hold all the relevant data in
>>>> arrays. Then make a 'construct_raster' method could return a
>>>> LineCollection. Then again, weren't you passing extra kwargs to
>>>> 'plot'? This approach would surely use ax.add_lines or
>>>> ax.add_linecollection something (I can't remember what it's called).
>>> The whole point of creating a new collection type is that artists will
>>> be able to manipulate individual sets of events.
>>>
>>> For example, with an ordinary LineCollection it will be extremely
>>> difficult to change the marker type, since doing so will change the
>>> marker for all 3 points on each segment rather than just the middle
>>> point.  So if someone makes the plot, than wants to set rows to have
>>> different marker types instead of being lines, they can do that if we
>>> use a new collection class.  But if we use LineCollection this becomes
>>> much more difficult.
>>>
>>> Similarly, with a LineCollection the lines lose their status as
>>> objects with a single distinct position.  They become objects with 3
>>> 2D coordinates.  So if someone wants to add more events to the end,
>>> they need to take care of handling the x and y coordinates, making
>>> sure the x coordinates are the same and taking the y coordinates from
>>> one of the existing lines. Similarly changing the height or vertical
>>> position of all the objects is complicated, having to manually
>>> calculate and modify the y coordinates of each point in each segment.
>>>
>>> Again, the idea here is to make the most common use-cases as easy as
>>> possible.  LineCollection objects aren't really suited to the sort of
>>> artistic changes that are typical with this sort of plot.
>>>
>>> In fact I would say that having a separate collection class is central
>>> to this idea.  If users aren't able to manipulate the set of events as
>>> such after they create the plot, then there really isn't any advantage
>>> over just using a vlines plot. Calculating the ymin and ymax is one
>>> line of code each, it is the artistic changes that save many lines of
>>> code and a lot of complexity.
>> I would also like to add that the new collection object would be
>> useful outside of this plot type.
>>
>> For example if someone wanted to create a rug plot as Nathaniel
>> described, and they want those along the same axes as the main plot,
>> then they would most likely not be be using the plot function, but
>> rather creating two individual collection objects in an existing
>> figure.
>>
>> I can imagine other cases besides a strict rug plot where adding such
>> a collection object could be useful.
> Now that 1.2 is out, can we revisit this?  I would like to get it
> implemented for the next feature release.
>

Absolutely.  I think the next step, once you have an implementation, 
would be to submit a pull request and we can all help with a review.

(BTW -- feel free to submit pull requests at any point in a release 
cycle -- we have both a master and a maintenance branch, so we can work 
on new stuff and stable stuff at the same time).

Mike

Re: [matplotlib-devel] New plot type idea -- EventRaster

[Todd <tod...@gm...>]

On Thu, Sep 27, 2012 at 8:18 PM, Todd <tod...@gm...> wrote:
> On Thu, Sep 27, 2012 at 1:44 PM, Todd <tod...@gm...> wrote:
>> On Thu, Sep 27, 2012 at 1:12 PM, Damon McDougall
>> <dam...@gm...> wrote:
>>> Hi Todd,
>>>
>>> Firstly, thanks for taking the time to crystallise your thoughts in
>>> words first. This is one of my bad habits; I tend to rush into things.
>>>
>>> I have some feedback for you, hopefully we can all work together to
>>> get this right. It's difficult when something new gets implemented and
>>> someone expects it to do something and the only way to resolve it is
>>> to break the calling API.
>>
>> Where is API broken?
>>
>>> Anyway, I hope you'll find my comments
>>> helpful at the least. I also encourage others to weigh in with
>>> opinions and ideas.
>>
>> Okay, I will discuss the rationale.  I will snip out anything you
>> agree on for brevity.
>>
>>>> Assuming we go with the name, here is my proposed call signature:
>>>>
>>>> EventRaster(x, offset=0, height=1, **kargs)
>>>
>>> CamelCase is discouraged for method names. Perhaps 'eventraster'?
>>
>> Fair enough.
>>
>>> Also, we could also let **kwargs swallow the 'offset' and 'height'
>>> keyword arguments. Then the user isn't constrained by which order to
>>> put them in. The downside of this approach is that introspection is
>>> more difficult.
>>
>> I don't understand the advantage of this approach.  If you use keyword
>> arguments, then the order doesn't matter.  So with the approach above
>> you can use keyword arguments, in which case you can use whatever
>> order they want, or you can use positional arguments.  On the other
>> hand putting it in **kwargs, we lose the ability to use positional
>> arguments.  So we lose nothing by allowing both positional and keyword
>> arguments.  It is also easier to implement.
>>
>>>> offset determines the positions of the rows.  By default, the first
>>>> row is placed with the line center y=0, and subsequent rows are placed
>>>> with the line centers at increasing 1-unit increments.  If offset is
>>>> defined and is a scalar, the first row is placed at the offset, and
>>>> subsequent rows are placed at increasing 1-unit increments.  If offset
>>>> is an array, it must be a 1D array of the same length as the second
>>>> dimension of x.  In this case each element in offset determines the
>>>> center of the corresponding row in the plot.
>>>
>>> How about letting offset be either: a) a scalar, determining the
>>> offset of all rows equally; or b) an array, determining the offset of
>>> each row individually.
>>
>> Because people are almost never going to want to have all the lines
>> stacked right on top of each other.  The plot would be indecipherable
>> that way.  The defaults are chosen to handle the most common use-cases
>> most easily.
>>
>>> In fact, why plot each row at integer y
>>> coordinates? Could we allow for an optional y-coordinate array, each
>>> element of which would be the y-coordinate at which to plot a row of
>>> lines. Then you wouldn't need offset.
>>
>> That is exactly what offset does if you pass an array.
>>
>>>> If this is going to be used to implement rug plots, it would need some
>>>> way to handle columns of horizontal lines in addition to rows of
>>>> vertical lines.  I see two ways to implement this.  First is to have
>>>> to plot types, perhaps HEventRaster and VEventRaster.  The first would
>>>> be as described above, while the second would be similar but
>>>> everything rotated 90 degrees.  Another possibility is to change the
>>>> call signature to this:
>>>>
>>>> EventRaster(x, y=None, offset=0, height=1, **kargs)
>>>
>>> I think accepting an 'orientation' kwarg, which can take either
>>> 'horizontal' or 'vertical', determining the orientation of the lines
>>> and reversing the roles of the x and y arrays.
>>
>> That would work as well.  Probably cleaner that way
>>
>>>> The function will return a list of a new collection type I am
>>>> tentatively calling EventCollection.  My thinking would be this would
>>>> be a subclass of a new collection type called GenericLineCollection,
>>>> which the current LineCollection would also subclass.  They would
>>>> share things like the color handling and segment handling, however the
>>>> segment handling will be a "private" method that LineCollection will
>>>> have a public wrapper for.  On the other hand methods to set or add
>>>> segments will remain private in EventCollection, although there will
>>>> be a method to return the segments if an artist really wants to
>>>> manipulate individual segments.
>>>
>>> Why can't we just use LineCollection? I don't see a good reason to
>>> create a new collection class here; the plot is simple.
>>
>> Explained below.
>>
>>>> The reason for doing it this way is that manipulating individual rows
>>>> of events should be very common, such as changing their position,
>>>> color, marker, width, and so on.  On the other hand manipulating lines
>>>> individually should not be as common, although still supported.
>>>
>>> Fair enough, then maybe a better idea is to create your own
>>> EventRaster class (note camel case) to hold all the relevant data in
>>> arrays. Then make a 'construct_raster' method could return a
>>> LineCollection. Then again, weren't you passing extra kwargs to
>>> 'plot'? This approach would surely use ax.add_lines or
>>> ax.add_linecollection something (I can't remember what it's called).
>>
>> The whole point of creating a new collection type is that artists will
>> be able to manipulate individual sets of events.
>>
>> For example, with an ordinary LineCollection it will be extremely
>> difficult to change the marker type, since doing so will change the
>> marker for all 3 points on each segment rather than just the middle
>> point.  So if someone makes the plot, than wants to set rows to have
>> different marker types instead of being lines, they can do that if we
>> use a new collection class.  But if we use LineCollection this becomes
>> much more difficult.
>>
>> Similarly, with a LineCollection the lines lose their status as
>> objects with a single distinct position.  They become objects with 3
>> 2D coordinates.  So if someone wants to add more events to the end,
>> they need to take care of handling the x and y coordinates, making
>> sure the x coordinates are the same and taking the y coordinates from
>> one of the existing lines. Similarly changing the height or vertical
>> position of all the objects is complicated, having to manually
>> calculate and modify the y coordinates of each point in each segment.
>>
>> Again, the idea here is to make the most common use-cases as easy as
>> possible.  LineCollection objects aren't really suited to the sort of
>> artistic changes that are typical with this sort of plot.
>>
>> In fact I would say that having a separate collection class is central
>> to this idea.  If users aren't able to manipulate the set of events as
>> such after they create the plot, then there really isn't any advantage
>> over just using a vlines plot. Calculating the ymin and ymax is one
>> line of code each, it is the artistic changes that save many lines of
>> code and a lot of complexity.
>
> I would also like to add that the new collection object would be
> useful outside of this plot type.
>
> For example if someone wanted to create a rug plot as Nathaniel
> described, and they want those along the same axes as the main plot,
> then they would most likely not be be using the plot function, but
> rather creating two individual collection objects in an existing
> figure.
>
> I can imagine other cases besides a strict rug plot where adding such
> a collection object could be useful.

Now that 1.2 is out, can we revisit this?  I would like to get it
implemented for the next feature release.

-Todd

Re: [matplotlib-devel] [PATCH] gtkagg backend leaks gc's.

[Benjamin R. <ben...@ou...>]

On Thursday, November 8, 2012, Carl Michal wrote:

> Hello,
>
> I noticed that a program I had that uses canvas.blit() to do animated
> graphs
> with the gtkagg backend was leaking memory.
>
> I tracked this down to gtk gc's being allocated in agg_to_gtk_drawable with
> gdk_gc_new(), but never being destroyed.
>
> The leak can be seen using the 'Animating selected plot elements' example
> from:
>
> http://www.scipy.org/Cookbook/Matplotlib/Animations
>
> (if it is modified to run forever, rather than just 50 plots and also
> changing numerix to numpy). After a few minutes, it is clear from ps that
> the
> memory usage is slowly but steadily climbing.
>
> Patch below (against matplotlib-1.1.1.) fixes it.
>
> Carl
>
> --- _gtkagg.cpp~        2012-06-30 12:37:00.000000000 -0700
> +++ _gtkagg.cpp 2012-11-08 14:30:23.000000000 -0800
> @@ -121,6 +121,7 @@
>                                   destbuffer,
>                                   deststride);
>
> +       gdk_gc_destroy(gc);
>             if (needfree)
>             {
>                 delete [] destbuffer;
>
>
>
>
If you are willing, would you like to file a PR against the v1.2.x branch?

Ben Root

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Damon M. <dam...@gm...>]

On Sun, Nov 11, 2012 at 12:19 PM, Fernando Perez <fpe...@gm...> wrote:
> On Sun, Nov 11, 2012 at 11:47 AM, Benjamin Root <ben...@ou...> wrote:
>> Don't see why not.  Thanks for the advertising!
>
> OK, so it will be!  Thanks again for everyone who made this possible!
>
> f

Yeah that's a great idea. Get the word out.

-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Fernando P. <fpe...@gm...>]

On Sun, Nov 11, 2012 at 11:47 AM, Benjamin Root <ben...@ou...> wrote:
> Don't see why not.  Thanks for the advertising!

OK, so it will be!  Thanks again for everyone who made this possible!

f

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Sandro T. <mo...@de...>]

On Thu, Nov 8, 2012 at 6:18 PM, Michael Droettboom <md...@st...> wrote:
> Thanks again to everyone for all of their hard work.  This release has
> been tagged and uploaded.

1.2.0 Debian packages has just landed in Debian experimental! Cheers :)

--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Benjamin R. <ben...@ou...>]

On Sunday, November 11, 2012, Fernando Perez wrote:

> On Thu, Nov 8, 2012 at 7:18 PM, Damon McDougall
> <dam...@gm... <javascript:;>> wrote:
> >> IIRC matplotlib is currently third in the list of libraries most wanted
> >> by users waiting for Python3 compatibility.  I'd guess that many
> >> scientific users are aware of this wonderful milestone, but to spread
> >> the news at a minimum I'd put this on the main Python mailing list and
> >
> > +1 for this
>
> I'm giving the closing keynote at PyCon Canada today, can I announce
> 1.2.0 offiical with py3 support then?  It would be a fitting tribute
> to John and the amazing work you have all put in moving the project
> forward!
>
> f


Don't see why not.  Thanks for the advertising!

Ben Root

Re: [matplotlib-devel] [Python-modules-team] Bug#608932: python-matplotlib-doc: "Exception occurred rendering plot"

[Sandro T. <mo...@de...>]

Hi all,

On Mon, Jan 17, 2011 at 11:45 PM, Sandro Tosi <mo...@de...> wrote:
> On Tue, Jan 4, 2011 at 19:11, Jakub Wilk <jw...@de...> wrote:
>> Package: python-matplotlib-doc
>> Version: 0.99.3-1
>> Severity: minor
>>
>> There are several "Exception occurred rendering plot" warnings in the
>> generated documentation:
>>
>> $ cd /usr/share/doc/python-matplotlib-doc/html/ && grep -r 'Exception
>> occurred' .

I'm not exactly sure how this has fixed itself, but now the above
command returns nothing (on 1.2.0 -doc package):

$ cd /usr/share/doc/python-matplotlib-doc/html/ && grep -r 'Exception
occurred' .
$

Hence closing this report.

Regards,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Fernando P. <fpe...@gm...>]

On Thu, Nov 8, 2012 at 7:18 PM, Damon McDougall
<dam...@gm...> wrote:
>> IIRC matplotlib is currently third in the list of libraries most wanted
>> by users waiting for Python3 compatibility.  I'd guess that many
>> scientific users are aware of this wonderful milestone, but to spread
>> the news at a minimum I'd put this on the main Python mailing list and
>
> +1 for this

I'm giving the closing keynote at PyCon Canada today, can I announce
1.2.0 offiical with py3 support then?  It would be a fitting tribute
to John and the amazing work you have all put in moving the project
forward!

f

Re: [matplotlib-devel] cbook.get_sample_data() and custom sample_data location

[Sandro T. <mo...@de...>]

Hi all again,

On Fri, Nov 9, 2012 at 11:53 PM, Sandro Tosi <mo...@de...> wrote:
> Hello,
> for the Debian package, we install sample_data directory in a custom
> location, /usr/share/matplotlib/sample_data/ .
>
> Pre-1.2.0 we could specify the examples.directory rcParam, but now
> that parameter has been removed.
>
> If we want to keep shipping sample_data in /usr/share/matplotlib/ , it
> seems the only solution is to patch cbook.get_sample_data() to set
>
> root = '/usr/share/matplotlib/'

Just hardcoding the path made the doc compilation failing to provide
the images for examples using get_sample_data() because it refers to a
directory still not populated (it will be at install time, not build
time). So i brought it up to
https://github.com/matplotlib/matplotlib/issues/1478

We can keep discussing it there.

Cheers,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi

[matplotlib-devel] cbook.get_sample_data() and custom sample_data location

[Sandro T. <mo...@de...>]

Hello,
for the Debian package, we install sample_data directory in a custom
location, /usr/share/matplotlib/sample_data/ .

Pre-1.2.0 we could specify the examples.directory rcParam, but now
that parameter has been removed.

If we want to keep shipping sample_data in /usr/share/matplotlib/ , it
seems the only solution is to patch cbook.get_sample_data() to set

root = '/usr/share/matplotlib/'

Is that correct or is there another solution i'm not seeing?

Regards,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Damon M. <dam...@gm...>]

On Thu, Nov 8, 2012 at 6:14 PM, Mark Lawrence <bre...@ya...> wrote:
> On 08/11/2012 17:18, Michael Droettboom wrote:
>> Thanks again to everyone for all of their hard work.
>
> Yep.  And a fantastic memorial in its own right to the late John Hunter.
>
>>
>> As per the usual drill, once we have the binaries up, I'll make an ANN
>> on matplotlib-users.
>
> IIRC matplotlib is currently third in the list of libraries most wanted
> by users waiting for Python3 compatibility.  I'd guess that many
> scientific users are aware of this wonderful milestone, but to spread
> the news at a minimum I'd put this on the main Python mailing list and

+1 for this

> on Python announce.  Or does that happen anyway, and I'd simply
> forgotten about it?
>
>>
>> The documentation is currently being rebuilt, and the default for
>> matplotlib.org will update to 1.2.0 around the same time as that
>> announcement.
>>
>> Mike
>>
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_nov
>>
>
> --
> Cheers.
>
> Mark Lawrence.
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel



-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

[matplotlib-devel] Fwd: 1.2.0 Final tagged and uploaded

[Damon M. <dam...@gm...>]

---------- Forwarded message ----------
From: Damon McDougall <dam...@gm...>
Date: Thu, Nov 8, 2012 at 6:16 PM
Subject: Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded
To: "Russell E. Owen" <ro...@uw...>


On Thu, Nov 8, 2012 at 5:52 PM, Russell E. Owen <ro...@uw...> wrote:
> In article <509...@st...>,
>  Michael Droettboom <md...@st...>
>  wrote:
>
>> Thanks again to everyone for all of their hard work.  This release has
>> been tagged and uploaded.
>>
>> As per the usual drill, once we have the binaries up, I'll make an ANN
>> on matplotlib-users.
>>
>> The documentation is currently being rebuilt, and the default for
>> matplotlib.org will update to 1.2.0 around the same time as that
>> announcement.
>>
>> Mike
>
> Congratulations!
>
> It looks like the binaries are all there (I uploaded the Mac binaries
> and found the Windows binaries already present).

Was waiting for your OK on this Russell. Glad to know they're building
fine. Good work.

--
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

Forgot to include everybody else.

-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Mark L. <bre...@ya...>]

On 08/11/2012 17:18, Michael Droettboom wrote:
> Thanks again to everyone for all of their hard work.

Yep.  And a fantastic memorial in its own right to the late John Hunter.

>
> As per the usual drill, once we have the binaries up, I'll make an ANN
> on matplotlib-users.

IIRC matplotlib is currently third in the list of libraries most wanted 
by users waiting for Python3 compatibility.  I'd guess that many 
scientific users are aware of this wonderful milestone, but to spread 
the news at a minimum I'd put this on the main Python mailing list and 
on Python announce.  Or does that happen anyway, and I'd simply 
forgotten about it?

>
> The documentation is currently being rebuilt, and the default for
> matplotlib.org will update to 1.2.0 around the same time as that
> announcement.
>
> Mike
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
>

-- 
Cheers.

Mark Lawrence.

Re: [matplotlib-devel] [PATCH] gtkagg backend leaks gc's.

[Carl M. <mi...@ph...>]

Hello,

I noticed that a program I had that uses canvas.blit() to do animated graphs 
with the gtkagg backend was leaking memory.

I tracked this down to gtk gc's being allocated in agg_to_gtk_drawable with 
gdk_gc_new(), but never being destroyed.

The leak can be seen using the 'Animating selected plot elements' example 
from:

http://www.scipy.org/Cookbook/Matplotlib/Animations

(if it is modified to run forever, rather than just 50 plots and also 
changing numerix to numpy). After a few minutes, it is clear from ps that the 
memory usage is slowly but steadily climbing.

Patch below (against matplotlib-1.1.1.) fixes it.

Carl

--- _gtkagg.cpp~        2012-06-30 12:37:00.000000000 -0700
+++ _gtkagg.cpp 2012-11-08 14:30:23.000000000 -0800
@@ -121,6 +121,7 @@
                                  destbuffer,
                                  deststride);

+       gdk_gc_destroy(gc);
            if (needfree)
            {
                delete [] destbuffer;

Re: [matplotlib-devel] 1.2.0 Final tagged and uploaded

[Russell E. O. <ro...@uw...>]

In article <509...@st...>,
 Michael Droettboom <md...@st...> 
 wrote:

> Thanks again to everyone for all of their hard work.  This release has 
> been tagged and uploaded.
> 
> As per the usual drill, once we have the binaries up, I'll make an ANN 
> on matplotlib-users.
> 
> The documentation is currently being rebuilt, and the default for 
> matplotlib.org will update to 1.2.0 around the same time as that 
> announcement.
> 
> Mike

Congratulations!

It looks like the binaries are all there (I uploaded the Mac binaries 
and found the Windows binaries already present).

-- Russell

[matplotlib-devel] 1.2.0 Final tagged and uploaded

[Michael D. <md...@st...>]

Thanks again to everyone for all of their hard work.  This release has 
been tagged and uploaded.

As per the usual drill, once we have the binaries up, I'll make an ANN 
on matplotlib-users.

The documentation is currently being rebuilt, and the default for 
matplotlib.org will update to 1.2.0 around the same time as that 
announcement.

Mike

Re: [matplotlib-devel] dead link on matplotlib.org page

[Michael D. <md...@st...>]

This will be addressed when I update the docs to 1.2.0 shortly.

Mike

On 11/08/2012 11:31 AM, Benjamin Root wrote:
> And I had completely missed that this was taken care of yesterday.  
> However, the changelog link from the what's new page is still dead.
>
> Ben
>
> On Thu, Nov 8, 2012 at 11:24 AM, Benjamin Root <ben...@ou... 
> <mailto:ben...@ou...>> wrote:
>
>     There is a link to the CHANGELOG (are we even keeping that up to
>     date anymore?) on the main page that is dead.
>
>     Ben Root
>
>
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
>
>
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel