#246 valgrind detects error in ATL_SetAllBitsBV

[Dave Nuechterlein]

:::C

To track down my intermittent error, I ran valgrind. It reports an error 3.11.31 in SetAllBitsBV when nmax was 8.

void ATL_SetAllBitsBV(int bv)
{
const int nbv = bv[1] ? bv[0]+1 : bv[0];
int bp = bv+2;
int i;
for (i=0; i < nbv; i++)
bp[nbv] = -1;
}

Shouldn't that be:

void ATL_SetAllBitsBV(int bv)
{
const int nbv = bv[1] ? bv[0]+1 : bv[0];
int bp = bv+2;
int i;
for (i=0; i < nbv; i++)
bp[ i ] = -1; // not nbv
}

[R. Clint Whaley]

Ticket moved from /p/math-atlas/support-requests/986/

[R. Clint Whaley]

I confirm this ATLAS bug, and your proposed fix. I have made the change to the basefile for the next release.

Thanks!
Clint