Menu

#183 HyperArch.py multibyte charset

Mailman 2.1
closed-accepted
nobody
Pipermail (42)
5
2002-12-08
2002-12-02
No

HyperArch.py in 2.1b5 use Utils.uquote() for
CGIescape() and html_quote() but it does not take
language argument. This is no good for multilbyte
charset because characters are escaped in separate 8bit
bytes which results in mojibake.
We should rather use Utils.uncanonstr() to honor the
legal characters within the multibyte charset.
This patch fixes other minor bugs in the current code.

Discussion

  • Tokio Kikuchi

    Tokio Kikuchi - 2002-12-02

    HyperArch.py.diff

     
  • Barry Warsaw

    Barry Warsaw - 2002-12-07
     
  • Barry Warsaw

    Barry Warsaw - 2002-12-07

    Logged In: YES
    user_id=12800

    Here's a new version of the patch that applies cleanly to
    current cvs. I'm not sure I'm testing it well enough, so
    could you take a look?

     
  • Martin v. Löwis

    Logged In: YES
    user_id=21627

    Tokio, can you please explain the problem in more detail?
    Utils.uquote will always return 7bit strings only,
    potentially with nested HTML character references. Why could
    this cause a problem in a multi-byte encoding? Can you refer
    to a page that looks incorrectly because of that?

     
  • Tokio Kikuchi

    Tokio Kikuchi - 2002-12-08

    Logged In: YES
    user_id=67709

    Thanks Barry. The patch was successfully applied and things
    are worklng better. (a new i18n problem in date format, though)

     
  • Tokio Kikuchi

    Tokio Kikuchi - 2002-12-08

    Logged In: YES
    user_id=67709

    I think I have to generate new translation regarding the
    date format problem. Sorry.

     
  • Barry Warsaw

    Barry Warsaw - 2002-12-08

    Logged In: YES
    user_id=12800

    Tokio, do you have an answer for Martin's question? If this
    solves a real problem w/ Japanese, I'm happy to apply it,
    but it would be good to have a sample or test case that
    fails without it.

     
  • Barry Warsaw

    Barry Warsaw - 2002-12-08

    Logged In: YES
    user_id=12800

    Never mind, I saw your follow up in mailman-i18n. That's
    good enough for me, so I'll apply the patch.

     
  • Barry Warsaw

    Barry Warsaw - 2002-12-08
    • status: open --> closed-accepted
     

Log in to post a comment.

MongoDB Logo MongoDB