Re: [PATCH] GPG key-fetching

[Brian W. <wa...@lo...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kevin: thanks for the patch! It looks good. The only thing I'd suggest is
using the statusbuffer to count the keys instead of parsing stderr (which is
localized by gettext when the user has set LANG to something other than
english). I'd need to check to see how older version of gpg behave, but the
current one gives the following output for key processing (for a key that is
already in the keyring):

% gpg --status-fd 2 --recv-keys 0x03a5e108
gpg: requesting key 03A5E108 from hkp://subkeys.pgp.net
[GNUPG:] IMPORT_OK 0 9DF03E983525486D544A1EF3FE4F5E7F03A5E108
gpg: key 03A5E108: "Brian Warner <wa...@lo...>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1
[GNUPG:] IMPORT_RES 1 0 0 0 1 0 0 0 0 0 0 0 0 0

The "gpg:" lines are stderr and can appear in other languages, the [GNUPG:]
lines are status-fd and are never localized. The GPG distribution has a
DETAILS file that specifies the format of that IMPORT_RES line: one of them
is a count of brand new keys, one is a count of updated keys, etc.

Kevin, do you have a sourceforge account? If you like, I'll add you to the
committers list so you can check this one in yourself.

I haven't had much time for mailcrypt recently, but we've got a lot of good
changes in CVS (like a fix to that long-standing non-ascii \201-inserting
bug) and we're *way* overdue for a new release. I'll try to schedule a
"mailcrypt day" next week and get 3.5.9 out.

The only big pending item is a mild tmpfile race insecurity, which can be
worked around by users telling mailcrypt to use ~/tmp/ instead of /tmp for
temporary files (the stderr/status-fd output holders). The proper fix is to
use make-temp-file instead of make-temp-name, which I haven't committed yet
because maintaining emacs20/XEmacs compatibility turned out to involve much
more work than I thought. I'm not sure I'll manage to get this part in before
a release, but I'll give it a shot. (I might fall back to using
make-temp-file if available, otherwise use the must-be-worked-around
make-temp-name function).

thanks!
 -Brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQE/oAwM/k9efwOl4QgRAoxhAJ98n7in6+wlDeBfP89RFgJmDjEeHgCfejrZ
F9O55rWMGFWCSXINVW2YEms=
=lVl0
-----END PGP SIGNATURE-----