Re: [Magpierss-general] ETag - case sensitivity reading header

[kellan <ke...@gm...>]

Thanks Phil, looks good, I'll add this patch.

-kellan

On 4/13/05, Phil Driscoll <ph...@di...> wrote:
> Hi
>=20
> I've just started using MagpieRSS (version 0.71.1)- thanks - it's great a=
nd I
> was up and running in a few minutes :)
>=20
> I have a bug fix I've applied to my version which someone might like to p=
ut in
> CVS.
>=20
> I was using the BBC news feed at
> http://news.bbc.co.uk/rss/newsonline_world_edition/uk_news/rss.xml
> and was getting a warning message telling me about an undefined symbol 'e=
tag'
> in rss_fetch.inc at line 156.
>=20
> On further investigation I discovered that the ETag header output by the =
BBC's
> Zeus web server contains 'Etag' rather than 'ETag' (lower case 't'). The =
code
> in MagpieRSS which reads the header (starting at line 305 in rss_fetch.in=
c)
> is doing a case sensitive check against 'ETag'. Consequently, $rss->etag =
does
> not get set.  As far as I can tell, the http header field names should be
> case insensitive. (http://www.w3.org/Protocols/rfc2616/rfc2616.html)
>=20
> I've modified my version of rss_fetch.inc so that the check for 'ETag' an=
d for
> 'Last-Modified' are case insensitive so that the code from line 305 reads=
 as
> follows:
>=20
>            if ( !strcasecmp ( $field, 'ETag' ) ) {
>                 $rss->etag =3D $val;
>             }
>=20
>             if ( !strcasecmp ( $field, 'Last-Modified' ) ) {
>                 $rss->last_modified =3D $val;
>             }
>=20
> And here's the same as a unified diff:
>=20
> --- /home/phil/old/rss_fetch.inc 2005-04-12 15:32:34.880643808 +0100
> +++ /home/phil/new/rss_fetch.inc 2005-04-13 11:32:57.523825194 +0100
> @@ -302,11 +302,11 @@
>                  $val =3D "";
>              }
>=20
> -            if ( $field =3D=3D 'ETag' ) {
> +            if ( !strcasecmp ( $field, 'ETag' ) ) {
>                  $rss->etag =3D $val;
>              }
>=20
> -            if ( $field =3D=3D 'Last-Modified' ) {
> +            if ( !strcasecmp ( $field, 'Last-Modified' ) ) {
>                  $rss->last_modified =3D $val;
>              }
>          }
>=20
> I hope others find this useful!
> --
> Phil Driscoll
>=20
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick
> _______________________________________________
> Magpierss-general mailing list
> Mag...@li...
> https://lists.sourceforge.net/lists/listinfo/magpierss-general
>=20
>