Re: [Madwifi-devel] [PATCH] Multicast reception broken with wpa_supplicant

[Bruno R. <bru...@4g...>]

hello alexander!

thank you for figuring that out and sorry for the late reply. i just commit=
ted=20
this to the CVS.=20

bruno



On Wednesday 10 August 2005 22:01, Alexander Pevzner wrote:
> Hello,
>
> in the infrastructure client mode, with WPA and wpa_supplicant,
> device unable to correctly receive broadcast/multicast frames from AP.
>
> The problem is that wpa_supplicant doesn't set IEEE80211_KEY_GROUP
> flag, when setting the group key (I use wpa_supplicant with
> driver_madwifi.c).
>
> Although I'm not sure should this problem be fixed in the driver or
> in the wpa_supplicant, I've created a one-line driver patch which
> fixes the problem.
>
> BTW, although this situation may be considered as a wpa_supplicant
> bug, the driver's behavior is anyway inconsistent: by the key
> index it decides that key is the group key, but neither verifies
> nor enforces the IEEE80211_KEY_GROUP flag.
>
> Yet another problem which I've noticed but not fixed: if packet
> doesn't decrypt, it is not dropped, but junk is delivered instead.
>
> The patch follows:
>
> Index: net80211/ieee80211_wireless.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- net80211/ieee80211_wireless.c	(revision 68)
> +++ net80211/ieee80211_wireless.c	(working copy)
> @@ -1841,6 +1841,7 @@
>  			return -EINVAL;
>  		wk =3D &ic->ic_nw_keys[kid];
>  		ni =3D NULL;
> +		ik->ik_flags |=3D IEEE80211_KEY_GROUP;
>  	}
>  	error =3D 0;
>  	ieee80211_key_update_begin(ic);