Re: [Madwifi-devel] Radiotap and FCS bytes
Status: Beta
Brought to you by:
otaku
From: Georg L. <ge...@bo...> - 2007-03-26 12:20:46
|
* Scott Raynel <sco...@gm...> [2007-03-25 09:17]: > On 25/03/2007, at 2:35 PM, Pavel Roskin wrote: > > Prism header - obsoleted by radiotap, should be removed before 0.9.4. I'm strongly against removing the prism headers, for two reasons: 1) there is no IsTX field in radiotap (which is really useful when analyzing the packets, and is required for at least what I am doing) 2) there are still many applications out there which only support prismhdr (but which we maybe don't know or never used). I would suggest to change the default header type to radiotap and first to see who starts crying - 100 lines of code in the driver are not such a heavy load for backward compatibility after all. > > Radiotap header - should be made default as soon as possible, so it > > gets some > > good testing before 0.9.4. Yes. > > Atheros header - it's a hack, although a potent one. It gives too > > much hardware > > control to the userspace. We may hear loud protests, but I think > > such code is > > better kept outside a production quality driver. Candidate for > > removal in > > 0.9.4. > Agreed. Atheros header support could be kept as an external patch > that people can apply if they really need it as an "unsupported" option. I'd rather like to see it as a build time option - external patches tend to become unmaintained and thus unusable. > I am inclined to think that removal of Prism support will cause more > "feedback" than removal of Atheros headers, but I guess we'll see :) > Hopefully the 0.9.4 development cycle will be shorter than 0.9.3 was, > so we can get the Atheros specific stuff out of net80211 ASAP. When having atheros specific stuff in net80211 is unwanted, maybe the API should be changed so that ath_pci is responsible for attaching a "hardware driver specific header" to the monitor frames? regards, Georg -- || http://op-co.de ++ GCS/CM d? s: a-- C+++ UL+++ !P L+++ E--- W++ ++ || gpg: 0x962FD2DE || N++ o? K- w---() O M V? PS+ PE-- Y+ PGP++ t* || || Ge0rG: euIRCnet || 5 X+ R tv b+(+++) DI+(+++) D+ G e* h! r* !y+ || ++ IRCnet OFTC OPN ||________________________________________________|| |