[Lxr-dev] [ lxr-Bugs-3466117 ] Bad action in change button for search script

[SourceForge.net <no...@so...>]

Bugs item #3466117, was opened at 2011-12-27 11:25
Message generated for change (Comment added) made by ajlittoz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3466117&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: current cvs
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Andre-Littoz (ajlittoz)
Assigned to: Andre-Littoz (ajlittoz)
Summary: Bad action in change button for search script

Initial Comment:
Under the buttons-and-menu interface, the change button in free-text searching screen contains an invalid action=$varbtnaction, i.e. template is not expanded.

In Template.pm, sub varbtnaction uses the existing fileref, diffref and idref subs to get a skeletal <a> link corresponding to scripts source, diff and ident respectively. Unhappily there is no such sub for search. varbtnaction generates directly the action, but the string then goes thru a pattern extraction to get the href target.

You should mock up a href also for search, otherwise the sub returns undef and the template $varbtnaction is left unchanged (not removed).

----------------------------------------------------------------------

>Comment By: Andre-Littoz (ajlittoz)
Date: 2011-12-27 11:26

Message:
sub varbtnaction in Template.pm is modified in such a way that all 4
different targets are processed the same.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3466117&group_id=27350