[Lxr-dev] [ lxr-Bugs-2787809 ] Weird ordering dependencies in Index implementations

[SourceForge.net <no...@so...>]

Bugs item #2787809, was opened at 2009-05-06 12:48
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787809&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Malcolm Box (mbox)
Summary: Weird ordering dependencies in Index implementations

Initial Comment:
The mysql.pm implementations of fileindexed/filereferenced & setfileindexed/setfilereferenced have a weird ordering requirement that the getter must be called before the setter will work, as the setter only does an UPDATE on the database, not an INSERT.  The INSERT is only performed by the getter.

While this works in practise because Tagger.pm always checks the status before setting, it is rather unnatural and should be removed.  The cost will be an extra SELECT against the database to establish whether the file is already listed - this is very low cost compared to other db operations going on for each file being indexed/referenced.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2009-05-12 16:55

Message:
Fixed by latest updates to the DB code

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787809&group_id=27350