[Lxr-dev] [ lxr-Bugs-1111786 ] Failure to open file not detected

[SourceForge.net <no...@so...>]

Bugs item #1111786, was opened at 2005-01-28 22:52
Message generated for change (Settings changed) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1111786&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: SCM support
>Group: current cvs
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Malcolm Box (mbox)
Summary: Failure to open file not detected

Initial Comment:
lxr-0.9.3, perl 5.8.2, running against a CVS tree.

The CVS code restricts the search path for "co"; in my
installation, it wasn't located in that path.  The
check for success running "co" looks at $fileh, but
open() sets $fileh regardless of success.  Instead,
check the return value from open() to determine whether
"co" was run successfully, e.g.

$rtn = open($fileh, "-|", "co -q -p$rev $clean_filename");
die ("...") unless $rtn;
(CVS.pm ca. line 170)

The open was failing silently, so the results from
genxref were all empty files.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1111786&group_id=27350