[Lxr-dev] [ lxr-Feature Requests-1691372 ] Rearchitect the LXR::Files class to LXR::File

[SourceForge.net <no...@so...>]

Feature Requests item #1691372, was opened at 2007-03-30 16:31
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=1691372&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Paul D. Smith (psmith)
Assigned to: Nobody/Anonymous (nobody)
Summary: Rearchitect the LXR::Files class to LXR::File

Initial Comment:
The current LXR::Files class has a single global object that represents a backend (plain, CVS, etc.)  Methods of this object take a filename/release pair and return various information about that file using that backend.

I don't think this is the proper organization and this should be rearchitected.  I propose the following:

1) The current LXR::Files class should be reworked to be a very small class, that just does whatever setup is needed for that backend type.  It could be renamed to something like LXR::FileType or something, maybe.  It's possible we won't even need this: we'll have to see.

2) A new LXR::File class should be created.  An object of this class will represent ONE file/release.  It will have various methods to retrieve the path, content, size, etc.; these don't need to take any arguments (generally).

LXR::File is probably going to be a superclass with subclasses for each backend, and the actual objects returned would be objects of the subclass.  The LXR::File class would provide basic method implementations (probably similar to today's LXR::Files::Plain class) which various other backends could override.

Once this is done I think a lot of other things, like the web caching described in another feature request, become more straightforward to implement.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2007-04-14 00:31

Message:
Logged In: YES 
user_id=215386
Originator: NO

Excellent idea, this would make a bunch of things easier and be higher
performance with certain SCM systems.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=1691372&group_id=27350