From: Paul S. <ps...@ne...> - 2007-03-22 16:37:23
|
On Thu, 2007-03-22 at 17:06 +0100, Jan-Benedict Glaw wrote: > > Critical to get in, IMO, are the enhancements to allow the code to work > > with MySQL 5 (the quoting of `release` so it's not considered a > > keyword). A number of the bugs and patches on the Savannah site all > > deal with this single issue. > > That may need a fix. If the DB backend gets rewritten to make deeper > use of the DBI interface (eg. don't do too much database specific > stuff), that'd hopefully be dropped altogether. > > Renaming the field to avoid the issue could help, too. > > And a Perl guru could have a look at the documentation to tell us if > DBI has a generic interface for prepared statements. The only thing I understood completely here was the second paragraph :). Renaming the column is fine with me but would mean we need to advise people who already have databases on how to use ALTER TABLE to fix their schema. Putting on my SCM hat, I'd suggest a good alternative name for "release" is "stream". Probably it's a good practice to have an "upgrade" script that people would invoke to move from an older to a newer version. As far as I'm aware there's no way to "make deeper use of the DBI interface" that would allow us to do something like ignore column names... ? And I'm not sure what you mean by a generic interface for prepared statements. Hm... maybe you mean using placeholders ("?") for column names as well as for values, as in: select ? from lxr_releases where ? = ? If so, that won't work. DBI supports placeholders ONLY for values, not for table/column/database names or other keywords. > The interesting part here is most probably to correctly deal with > dropping the old tables... Which old tables would we want to drop? -- ----------------------------------------------------------------------------- Paul D. Smith <ps...@ne...> http://netezza.com "Please remain calm--I may be mad, but I am a professional."--Mad Scientist ----------------------------------------------------------------------------- These are my opinions--Netezza takes no responsibility for them. |