[Lxr-dev] [ lxr-Bugs-1322202 ] source does not enter 2-letters dirs

[SourceForge.net <no...@so...>]

Bugs item #1322202, was opened at 2005-10-10 04:04
Message generated for change (Comment added) made by darellik
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1322202&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: None
Status: Closed
Resolution: Duplicate
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: source does not enter 2-letters dirs

Initial Comment:
(LXR 0.9.4)

The source script refuses to enter a 2 letters dir
(such as 'fs' or 'mm' in linux kernel source tree).

The problem comes from a misuse of the dot in the
regexp used to filter out the .. (parent) dir.

Fixup : apply following patch (do not forget to apply
to the perl-mods
installed in the /usr/.../site_lisp perl directory if 
you followd install directives)

--- LXR/Common.pm       2005-10-07 15:21:11.000000000 +0200
+++ LXR/Common.pm~      2005-10-05 17:55:19.000000000 +0200
@@ -541,7 +541,7 @@
                # First suppress anything after a dodgy
character
                $path =~ s!(^[\w_+-,.%^/]+).*!$1!;
                # Clean out /../
-               while ($path =~ m!/\.\./!) {
+               while ($path =~ m!/../!) {
                        $path = s!/\.\./!/!g;
                }
        }



----------------------------------------------------------------------

Comment By: Nick Jones (darellik)
Date: 2005-12-01 08:46

Message:
Logged In: YES 
user_id=119409

I just came upon this problem and this patch is backwards. 
It should read:

--- LXR/Common.pm 2005-10-07 15:21:11.000000000 +0200
+++ LXR/Common.pm 2005-10-05 17:55:19.000000000 +0200
@@ -541,7 +541,7 @@
# First suppress anything after a dodgy
character
$path =~ s!(^[\w_+-,.%^/]+).*!$1!;
# Clean out /../
- while ($path =~ m!/../!) {
+ while ($path =~ m!/\.\./!) {
$path = s!/\.\./!/!g;
}
}

----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2005-10-31 16:57

Message:
Logged In: YES 
user_id=215386

This has now been fixed in CVS.

If you can install the new version and check that it solves your
problem, then it would be very useful.

Thanks for reporting this defect and helping to make LXR better.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1322202&group_id=27350