[Lxr-dev] [ lxr-Bugs-1230443 ] Two letter directories fail

[SourceForge.net <no...@so...>]

Bugs item #1230443, was opened at 2005-06-30 17:20
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1230443&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: v0.9.4
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Malcolm Box (mbox)
Summary: Two letter directories fail

Initial Comment:
Using version 0.9.4
no error messages
Postgres DB
Plain Files

Path names consisting of only 2 letters are not 
displayed. E.g. browsing in linux/fs/ the displayed 
directory remains at linux/.

Found the bug in sub clean_path:
# Clean out /../
                while ($path =~ m!/../!) {
                        $path = s!/\.\./!/!g;

The first regex matches any two letters, it should be 
escaped with \:
# Clean out /../
                while ($path =~ m!/\.\./!) {
                        $path = s!/\.\./!/!g;



feedback or questions to: t.lehnig <at> gmx <dot> de.


----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2005-09-09 23:08

Message:
Logged In: YES 
user_id=215386

This has now been fixed in CVS.

If you can install the new version and check that it solves your
problem, then it would be very useful.

Thanks for reporting this defect and helping to make LXR better.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2005-07-14 08:58

Message:
Logged In: NO 

--- Common.pm.old       2005-07-14 15:54:29.000000000 +0800
+++ Common.pm   2005-07-14 15:55:21.000000000 +0800
@@ -541,7 +541,7 @@
                # First suppress anything after a dodgy
character
                $path =~ s!(^[\w_+-,.%^/]+).*!$1!;
                # Clean out /../
-               while ($path =~ m!/../!) {
+               while ($path =~ m!/\.\./!) {
                        $path = s!/\.\./!/!g;
                }
        }

I found the problem, too

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1230443&group_id=27350