[Lxr-dev] Re: [Lxr-commits] CVS: lxr/lib/LXR/Index Mysql.pm,1.16,1.17 Oracle.pm,1.5,1.6 Postgres.pm,1.15,1.16

[Malcolm B. <ma...@br...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dave Brondsema wrote:

| Update of /cvsroot/lxr/lxr/lib/LXR/Index
| In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22189/lib/LXR/Index
|
| Modified Files:
| 	Mysql.pm Oracle.pm Postgres.pm
| Log Message:
| prefix tables with lxr_ (configurable).  existing users should set
dbprefix to '' since their tables have no prefix

I suggest that this should work the other way round - if dbprefix is set
then it is used, otherwise the existing behaviour is preserved.  One
good reason for this is that setting dbprefix to '' doesn't seem to work
~  - the test in Mysql.pm is:

if ($config->{'dbprefix'}) {
~                $prefix = $config->{'dbprefix'};
~        } else {
~                $prefix = "lxr_";
~        }

and if dbprefix is '' then the test will fail.

Is there any strong reason for changing the default behaviour?

Cheers,

Malcolm
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (MingW32)
Comment: Using GnuPG with MultiZilla - http://enigmail.mozdev.org

iD8DBQFBBaHaQeMefPKyX/QRAlxZAKCmywUY7bpPcIOSb/AvR6Z9CuFDywCfQKay
onQluup8VH003ZjeZE53PeY=
=RjDe
-----END PGP SIGNATURE-----