Re: [Lxr-dev] Re: [Lxr-commits] CVS: lxr INSTALL,1.15,1.16 find,1.21,1.22 genxref,1.34,1.35 search,1.22,1.23

[Jan-Benedict G. <jb...@lu...>]

On Mon, 2004-07-19 16:58:22 -0400, Dave Brondsema <da...@br...>
wrote in message <Pine.LNX.4.58.0407191657170.6009@ferrari>:
> On Mon, 19 Jul 2004, Jan-Benedict Glaw wrote:
> > > --- genxref	19 Jul 2004 19:50:20 -0000	1.34
> > > +++ genxref	19 Jul 2004 20:03:31 -0000	1.35
> > > @@ -177,7 +177,7 @@
> > >  		system("chmod 644 $string");
> > >  	}
> > >
> > > -	if ( $config->swishdir and $config->swishindex ) {
> > > +	if ( $config->swishdir and $config->swishbin ) {
> > >  		my $swish =3D new IO::Handle;
> > >  		die $config->swishdir . " does not exist" unless -d $config->swish=
dir;
> > >  		my $filelist =3D new IO::File $config->swishdir . "/$release.filen=
ames", "w"
> >
> > Dito. Oh, and consistent space before an opening brace would also be
> > cool:) In the long run, of course...
> >
>=20
> I'll work on tweaking PerlTidy's configuration tomorrow.  Any other
> formatting suggestions?

*Personally*, I'd suggest something like

if ($blah) {
	something;
}

for braces, one space around concatenation dots and one space behind
comma (but none before).

Comments?

MfG, JBG

--=20
   Jan-Benedict Glaw       jb...@lu...    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier B=FCrger" | im Internet! |   im Ira=
k!
   ret =3D do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TC=
PA));