[Lxr-dev] Re: [Lxr-commits] CVS: lxr INSTALL,1.15,1.16 find,1.21,1.22 genxref,1.34,1.35 search,1.22,1.23

[Dave B. <da...@br...>]

On Mon, 19 Jul 2004, Jan-Benedict Glaw wrote:

> On Mon, 2004-07-19 13:03:34 -0700, Dave Brondsema <bro...@us...>
> wrote in message <E1B...@sc...>:
> > --- find	19 Jul 2004 19:50:20 -0000	1.21
> > +++ find	19 Jul 2004 20:03:31 -0000	1.22
> > @@ -112,7 +112,7 @@
> >  	my $casesensitive = $HTTP->{'param'}->{'casesensitive'};
> >
> >  	my $FILELISTING;
> > -	if ( $config->swishdir and $config->swishindex ) {
> > +	if ( $config->swishdir and $config->swishbin ) {
> >  		unless ( $FILELISTING = new IO::File( $config->swishdir . "/$release.filenames" ) ) {
>                       ^^^
> >  			&warning(
> >  "Version '$release' has not been indexed and is unavailable for searching<br>Could not open "
> >
>
> May I suggest to remove spaces after opening brace and before closing
> brace in the long term? At least, I think that looks better (well, for
> my eyes), but you may have another opinion about it...
>
> > --- genxref	19 Jul 2004 19:50:20 -0000	1.34
> > +++ genxref	19 Jul 2004 20:03:31 -0000	1.35
> > @@ -177,7 +177,7 @@
> >  		system("chmod 644 $string");
> >  	}
> >
> > -	if ( $config->swishdir and $config->swishindex ) {
> > +	if ( $config->swishdir and $config->swishbin ) {
> >  		my $swish = new IO::Handle;
> >  		die $config->swishdir . " does not exist" unless -d $config->swishdir;
> >  		my $filelist = new IO::File $config->swishdir . "/$release.filenames", "w"
>
> Dito. Oh, and consistent space before an opening brace would also be
> cool:) In the long run, of course...
>

I'll work on tweaking PerlTidy's configuration tomorrow.  Any other
formatting suggestions?

-- 
Dave Brondsema : da...@br...
http://www.brondsema.net : personal
http://www.splike.com : programming
http://csx.calvin.edu : student org