Re: [Lxr-dev] Solution for "Don't require glimpse for file search"

[Shree K. <sh...@pr...>]

Hi Malcolm,

> This looks like a neat addition.   I'm a little worried by memory usage
> - there are lxr installs with tens of thousands of files in them per
> release - have you tried to measure the impact of reading substantial
> numbers of filenames into memory?

No, I haven't measured the memory impact. The easiest solution for this
would be to filter by the regexp while executing the query itself,and 
only add the files that match the regexp to the return list. This must 
drastically reduce the memory usage as unneeded files will not be 
retained in memory.

>  From the pov of accepting this patch, it would be much easier for me if
> you sent the output of either diff -du or cvs diff -du.  Then applying
> the patch is automatic rather than requiring manual editing.

Yes, that's correct. I actually edited the diff output and sent it.

If the above change is OK, then I can post a patch immediately.

Cheers,

Shree Kumar