Re: [Lxr-dev] Solution for "Don't require glimpse for file search"

[Malcolm B. <ma...@br...>]

Hi Shree,

> The idea is to get the list of all files in a particular release and
> filter the list using the regular expression specified by the user.

This looks like a neat addition.   I'm a little worried by memory usage 
- there are lxr installs with tens of thousands of files in them per 
release - have you tried to measure the impact of reading substantial 
numbers of filenames into memory?

 From the pov of accepting this patch, it would be much easier for me if 
you sent the output of either diff -du or cvs diff -du.  Then applying 
the patch is automatic rather than requiring manual editing.

Cheers,

Malcolm