Re: [Lxr-dev] Problem with glimpse and CVS

[Malcolm B. <ma...@br...>]

Christian Robottom Reis wrote:
>
> How would you advise the fix to be done? I've added a $glimpsedatadir
> variable and used that as a prefix for the glimpse files, but I'm not sure
> if you agree with that approach. If so, patch in hand.

Well, the very best approach would be to do what the new swish-e code
does, and retrieve the file via the Files interface for display.  This
would then automatically work with CVS, plain and any other file backend
created.

I'm not sure how easy that will be to do - I know glimpse by default
wants to go and actually grep through the files to find exact line
numbers, and you may not want to give that functionality up.  In which
case, the glimpsedatadir solution is probably the best (though you then
have to ask "why not use Plain.pm anyway, since you've got a fully
checked-out tree?).

> Should I be using CVS?

Patches against CVS are usually easier for me to apply, but against a
known revision is also OK.

Regards,

Malcolm