Re: [Lxr-dev] [ lxr-Patches-452422 ] html validator

[Jason D. S. <js...@de...>]

Malcolm Box wrote:
> 
> no...@so... wrote:
> <snip>
> > A potential problem is that the image is only supposed
> > to be used on HTML pages that validate, which some
> > (perhaps most) of LXR is not.  The solution here, of
> > course, is to fix the HTML.
> 
> I haven't checked the html output - does it not verify against 3.2?  If
> not then we should stop displaying the icon.  Having said that I'm about
> to start a serious re-jig of the output side of lxr anyway...

No, it doesn't verify.  The first thing it notes is that html-head.html
has some spurious backslashes in it, but when this is fixed the checker
complains that in the code
  <th width="5%">
the % sign is not allowed.  This seems odd to me; I always thought that
was standard.  The checker says there may be a missing header needed to
declare the extensions being used.

I'm not sure what to make of it.  If I understood it, I'd probably have
gone ahead and fixed it...

> > I believe the templates should be very generic.  This
> > isn't the only problem with them, there's also the
> > broken penguin picture (which is not generic at all).
> 
> I agree - I think the templates could use a general overhaul, so I will
> hold off applying this patch in the hopes someone will take the time to
> do a complete overhaul.
> 
> If the html does validate, I think having the icon is appropriate so
> should stay in the template.  As for the rest, perhaps "This is a demo
> lxr site" sort of text would be best for the distributed templates?

I'd rather the templates be actually usable by a new LXR site.  This
should be easy enough to do.

BTW, my patch leaves the icon in the template, it just links to it
remotely instead of (incorrectly) assuming it's stored locally.

jason