Re: [Lxr-dev] Re: /bin/true as a zombie

[<pe...@kl...>]

Jason Dorje Short <js...@de...> writes:

> No doubt I'm missing something, but I don't understand why my change was
> conceptually wrong.  I took each version to be indexed, and traversed
> the tree for that version.  

But you can't find the versions to be indexed by asking for the
versions of the root of the tree.  In a CVS tree, each file can have a
differing number of versions, have completely different tags, etc.

> The current/former behavior is to traverse the tree, and for each
> file index it for all possible versions.  

Yes, that was the point.  Unless you specify a version, you get all
the versions a file has to offer.

That was at least the concept I had of --allversions, and your patch
didn't fit that concept.  Hence conceptually wrong.  It may of course
well be that my concepts are different from yours, in which case it's
a matter of opinion which version (pun intended) to hold as the
correct one.

> BTW, the new genxref doesn't work for me again.  It runs through all
> versions just as if everything had already been indexed, even
> immediately after I drop and re-create the database.

Maybe this is because Plain.pm and CVS.pm disagree on how to compute
allreleases?  I've never looked at Plain.pm, so I don't know.

It seems to me that this is an area that needs more customization,
because we obviously disagree, and I suspect that we both have equally
valid views.  And as it so happens, we have a configuration variable
by the name of 'range'.  Would you be happy if --allversions just used
the range in lxr.conf?

I've already patched Config.pm to accept closures for this variable in
order to get the cgi scripts to display versions based on the versions
of each file, so I think I could make this work for me.

It would still need to use the original control flow in order to allow
the flexibility I need, but specifying a constant range list (or file)
in lxr.conf should give the same semantics as precomputing the
versions to index, should it not?

...Peder...
-- 
This must be Thursday.  I never could get the hang of Thursdays.