Bugs item #695697, was opened at 2003-03-02 04:24
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=695697&group_id=27350
Category: Browsing
Group: unknown
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Silently corrupting source code on lxr.linux.no
Initial Comment:
Hi,
LXR on lxr.linux.no is silently corrupting data. In
particular, where the Linux kernel contains the string
"0" (including the quotes) it is being displayed as "",
which completely changes the meaning of the code. ("0"
is often used as a constraint for inline assembly).
The file I have noticed this in is
include/asm-i386/uaccess.h. It seems to affect all
versions of the file, and all places where the string
"0" is used in that file. Here are some sample URLs
(compare with your real kernel sources):
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L174
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L209
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L247
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L273
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L301
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L341
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L360
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L379
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L401
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L431
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L463
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L495
http://lxr.linux.no/source/include/asm-i386/uaccess.h#L537
http://lxr.linux.no/source/include/asm-i386/uaccess.h?v=2.4.18#L112
... and others on the same page
http://lxr.linux.no/source/include/asm-i386/uaccess.h?v=2.5.56#L117
... and others on the same page
And it's not just that file:
http://lxr.linux.no/source/include/asm-x86_64/uaccess.h#L190
http://lxr.linux.no/source/include/asm-x86_64/uaccess.h#L229
Interestingly, it appears that the freetext search is
using the correct, unmodified data. E.g.:
http://lxr.linux.no/search?string=%5C%28__m%5C%28addr%5C%29%5C%29
The first few result lines all contain "0", and it is
displayed correctly in the search results screen, but
the hyperlink takes you to the corrupted file.
Thanks for the great tool - I use lxr.linux.no a lot,
and really appreciate it. However, silently corrupting
code is not good...
Kind regards,
Jon Foster
----------------------------------------------------------------------
>Comment By: Malcolm Box (mbox)
Date: 2003-04-01 07:47
Message:
Logged In: YES
user_id=215386
The version of lxr running on lxr.linux.no is the old 0.3
code, which is no longer being actively maintained. I also
don't have access to the machine to change things over.
If you can see this problem with a recent (0.9.2) version of
LXR please let me know.
Malcolm
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=695697&group_id=27350
|
