Thread: [Lxr-dev] CSS support
Brought to you by:
ajlittoz
From: Pavel H. <pa...@gi...> - 2001-08-21 08:55:40
|
Hi all, I subscribed, because I was challenged here: <http://sourceforge.net/forum/forum.php?thread_id=132400&forum_id=86144> I'll be able to start the development this week (I hope :), so I'l like to ask if you are planning some big changes in the CVS tree. In this case it'd be better to hold on for few days. Changes to be made are just dirty work rather then sophisticated tweaking, but it will affect many lines in several files (CGI scripts and Common.pm according to my preliminary research) - I'd like to avoid conflicts. Another question is the form work is to be done. Should I checkout the main trunk and send the patch against it? If you are planning some bigger changes in about two weeks, it could be a good idea to start a new branch for this task. Merging CVS branches is more confortable then aplying patches in changed code (just my opinion). Looking forward for your comments. Pavel -- Pavel Hlavnicka Ginger Alliance www.gingerall.com |
From: Pavel H. <pa...@gi...> - 2001-09-03 12:39:24
|
I recently submitted the CSS support patch. Take a look. Pavel -- Pavel Hlavnicka Ginger Alliance www.gingerall.com |
From: Malcolm B. <ma...@br...> - 2001-09-27 14:23:40
|
Hi Pavel, This patch looks good - I've been testing it out here and it's working well so far. If nothing goes wrong I should have it submitted to the tree in a couple of days. Thanks for putting this together - CSS support is a really nifty feature to have. Cheers, Malcolm Pavel Hlavnicka wrote: > > I recently submitted the CSS support patch. Take a look. > > Pavel > > -- > Pavel Hlavnicka > Ginger Alliance > www.gingerall.com > > _______________________________________________ > Lxr-developer mailing list > Lxr...@li... > https://lists.sourceforge.net/lists/listinfo/lxr-developer |
From: Pavel H. <pa...@gi...> - 2001-09-27 14:30:27
|
Malcom, I'm glad to hear it. Note, that the second version of patch enhances the ident script, so it uses template instead of hardcoded markup. It's a good idea too, I guess. If you submit changed to main trunk, we may start some discussion about disabling/enabling css support at all. May be it would be a fine feature for some people. Some updates for serach page (glimpse) remains. Pavel Malcolm Box wrote: > Hi Pavel, > > This patch looks good - I've been testing it out here and it's working > well so far. If nothing goes wrong I should have it submitted to the > tree in a couple of days. > > Thanks for putting this together - CSS support is a really nifty feature > to have. > > Cheers, > > Malcolm > > Pavel Hlavnicka wrote: > >>I recently submitted the CSS support patch. Take a look. >> >>Pavel >> >>-- >>Pavel Hlavnicka >>Ginger Alliance >>www.gingerall.com >> >>_______________________________________________ >>Lxr-developer mailing list >>Lxr...@li... >>https://lists.sourceforge.net/lists/listinfo/lxr-developer >> -- Pavel Hlavnicka Ginger Alliance www.gingerall.com |
From: Malcolm B. <ma...@br...> - 2001-09-27 15:21:37
|
Pavel Hlavnicka wrote: > > Malcom, > > I'm glad to hear it. > > Note, that the second version of patch enhances the ident script, so it > uses template instead of hardcoded markup. It's a good idea too, I guess. Yes, using templates for the ident scripts is good. > If you submit changed to main trunk, we may start some discussion about > disabling/enabling css support at all. May be it would be a fine feature > for some people. It might indeed spark some discussion on having CSS. Perhaps if anyone feels strongly that this shouldn't go in/be enabled by default they should speak now... Cheers, Malcolm |
From: <no...@so...> - 2001-09-03 12:33:53
|
Patches item #458027, was opened at 2001-09-03 05:33 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=390119&aid=458027&group_id=27350 Category: Browsing Group: Experimental Status: Open Resolution: None Priority: 5 Submitted By: Pavel Hlavnicka (pavel_hlavnicka) Assigned to: Nobody/Anonymous (nobody) Summary: CSS support Initial Comment: This patch modifies current source, so that support CSS much more then the current main trunk version (where the css support is actually almost zero). Apply as patch -p0 < lxr-css.patch in the lxr directory; make sure, that directory ../lxr doesn't exist (if you have more then one copy). Template stylesheet file is templates/lxr.css. The stylesheet to be used is defined in the configuration file near the header and footer templates. The template $stylesheet is supported while the header template is expanded. See html-head.html for more. My goal was to fix all places, where markup is generated from code. 80% of changes affects the link (<a>) output. I extended the prototype of the 'fileref' function and Co. The second parameter of those functions is the style to be used (put into the 'class' attribute). I fixed all references to those call over all the code. The remaining 20% are changes related to the rest of the generated markup. i used the <span> tag for formating. Issues: - templates vs. generated code: some pages are generated completely (e.g search results, so user have no chance to change them. To make this situation better, I ... (see next bullet) - I removed the <ul> and <li> tags in the ident page (where references to searched symbol are displayed), so browsers, such is Lynx, could have problems. As I said above, the better solution would be the template support for this page. - Glimpse searches are not supported yet - I didn't understand all stuff in the 'markupfile' function. The highlighted files work well, but I didn't get, what are the other formats good for - Perl comments may be formatted incorrectly (just feeling :) - I used my favorite colors and non-underlined links, somebody else may dislike it - I changed the header template, so tables are used; however formatting of the menu (modes) is still a bit ugly - I added as few class specs. into templates as possible, some work is to be done here I'm looking forward to hear your comments Pavel ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=390119&aid=458027&group_id=27350 |