lxr-developer — Don't use, active developers only

[Lxr-dev] [ lxr-Bugs-516458 ] genxref (LXR 0.9.1) error

[<no...@so...>]

Bugs item #516458, was opened at 2002-02-12 07:40
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=516458&group_id=27350

Category: genxref
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Bernhard Penz (bpenz)
Assigned to: Nobody/Anonymous (nobody)
Summary: genxref (LXR 0.9.1) error

Initial Comment:
Hello,

I am running LXR 0.9.1 on a Linux box with Mysql Ver 
11.15 Distrib 3.23.41. I am trying to cross-reference 
plain files for the moment.

When I run './genxref --url=http://mylxr.srv/lxr' I 
get the following error message:

Can't locate DBI.pm in @INC (@INC contains: 
lib /usr/lib/perl5/5.6.1/i586-
linux /usr/lib/perl5/5.6.1 /usr/lib/perl5/site_perl/5.6
.1/i586-
linux /usr/lib/perl5/site_perl/5.6.1 /usr/lib/perl5/sit
e_perl .) 
at /usr/lib/perl5/site_perl/LXR/Index/Mysql.pm line 
24, <CONFIG> line 1.
BEGIN failed--compilation aborted 
at /usr/lib/perl5/site_perl/LXR/Index/Mysql.pm line 
24, <CONFIG> line 1.
Compilation failed in require 
at /usr/lib/perl5/site_perl/LXR/Index/DBI.pm line 30, 
<CONFIG> line 1.

Changing line 24 in Mysql.pm from 'use DBI;' to 'use 
LXR::Index::DBI;' ends up in this error message:

Can't locate object method "connect" via package "DBI" 
(perhaps you forgot to load "DBI"?) 
at /usr/lib/perl5/site_perl/LXR/Index/Mysql.pm line 
40, <CONFIG> line 1.

and there I am stuck because when I look in DBI.pm 
there is only one function named 'new' definded.

Thanks for your help,
Berni

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=516458&group_id=27350

[Lxr-dev] [ lxr-Bugs-515764 ] lxr 0.9 source brwosing doesn't work for

[<no...@so...>]

Bugs item #515764, was opened at 2002-02-10 22:33
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=515764&group_id=27350

Category: None
Group: None
Status: Closed
Resolution: Works For Me
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: lxr 0.9 source brwosing doesn't work for

Initial Comment:
We've tried the standard configuration as in lxr.conf 
to index a non-CVSed source. The indexing seems to 
work (checked up the mysql database for the symbols), 
however browsing the source shows the root-directory 
of the system and does not browse the actual 
sourceroot. Is there something to be done in the 
configuration to make it work? Is there an lxr.conf 
that runs out of the box?


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2002-02-12 02:26

Message:
Logged In: NO 

I had configured lxr to work with sourceurl as 
http://192.168.1.xx/ while $HTTP->{'this_url'} was 
returning http://ghost.codito.co.in/ which wasn't found in 
the lxr.conf (as sourceurl). I changed sourceurl in 
lxr.conf to http://ghost.codito.co.in/ and everything 
works fine. Is there a way to set aliases for sourceurl or 
if not, does it make sense to write an extension to do it?


----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2002-02-11 06:28

Message:
Logged In: YES 
user_id=215386

What URL are you looking at when it shows the system root? 
The correct URL should be something like
http://yourdomain/lxr/source to show the sourceroot.

If you want to, you can configure apache to default to this
URL when fed with http://yourdomain/lxr/


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=515764&group_id=27350

[Lxr-dev] Regular Expression search for identifiers

[Shree K. <sh...@pr...>]

It would be nice to allow a user to search for an identifier by
specifying
a regular expression.

Here are a few changes I made to the LXR 0.9 code to allow this.

The solution given here is MySQL based but must be possible using other
database backends as well. The patches are for LXR-0.9, though they
might
work for LXR-0.9.1 as well.

-----------------------------------------------------------------------

First, add the following lines to the "new" function in mysql.pm :

----
# Current idea is to return names of all identifiers, and
# let Perl regular expressions do the magic rather that
# use the regular expressions in MySQL - this makes it trivial
# to use this approach with other DBMSs and DB_File
        $self->{all_ident_select} = $self->{dbh}->prepare
                ("select distinct s.symname ".
                 "from symbols s, indexes i, files f, releases r ".
                 "where s.symid = i.symid and i.fileid = f.fileid ".
                 "and f.fileid = r.fileid ".
                 "and r.release = ?");
----

And add a new function "getallident" to mysql.pm :

----
# Added for regular expression identifier search support
sub getallident {
        my ($self, $symname, $release) = @_;
        my ($rows, @ret);

        $rows = $self->{all_ident_select}->execute("$release");

        while ($rows-- > 0) {
                push(@ret,[$self->{all_ident_select}->fetchrow_array]);
        }

        $self->{all_ident_select}->finish();
        map { $$_[3] &&= $self->symname($$_[3]) } @ret;

        return @ret;
}

--------------------------------------------------------------------------

Add a new function "regexp_search" to the "ident" script.

--------------------------------------------------------------------------
sub regexp_search
{
        if ($identifier eq "") {
                return
        }
        # get the list of all identifiers
        my @refs = $index->getallident($identifier, $release);

        my @ident=();
        my $def;
        my $ident;
        my $temp;
        my $count=0;
        while ($def = shift(@refs)) {
                ($ident)=@$def;

	        # filter using the regexp - ignore case 
                if ($ident =~ /$identifier/i) {
                        push(@ident,$ident);
                        $count++;
                }
        }
        if(($count>1) || (($count == 1 ) and ($identifier ne
$ident[0]))){
                print("<h3>Regexp \"$identifier\" - ". ($count) ."
matching identifiers found</h3>\n");
                my $vallink;
                while(@ident) {
                        $ident = shift(@ident);
                        $vallink = &idref($ident, "varlink", $ident,
"i=$ident");
                print("$vallink<br>\n");
                }
        }
}

And after the "printident" function call, add a call to "regexp_search"
--------------------------------------------------------------------------

Now, search for identifiers using regular expressions - .* must give all
the identifiers

- Shree Kumar

[Lxr-dev] Solution for "Don't require glimpse for file search"

[Shree K. <sh...@pr...>]

This is in response to the feature request "Don't require glimpse for
file search"

As was indicated in the request, there is no need to use glimpse as all
the
filename are present in the database...

The idea is to get the list of all files in a particular release and
filter the list using the regular expression specified by the user.

First, we have to have a "getallfiles" method in MySQL.pm 
-------------------------------------------------------------------------------
Add the following to the "new" method:

 $self->{all_files_select} = $self->{dbh}->prepare
               ("select distinct f.filename ".
                "from symbols s, indexes i, files f, releases r ".
                "where s.symid = i.symid and i.fileid = f.fileid ".
                "and r.release = ?");

And add the new function:

 sub getallfiles {
       my ($self,$release) = @_;
       my ($rows, @ret);

       $rows = $self->{all_files_select}->execute($release);

       while ($rows-- > 0) {
               push(@ret, $self->{all_files_select}->fetchrow_array);
       }
       $self->{all_files_select}->finish();

       return @ret;
 }
-------------------------------------------------------------------------------

Now apply the following patch to "find":
-------------------------------------------------------------------------------
<       unless
(open(FILELLISTING,$config->glimpsedir."/.glimpse_filenames")) {
<           &warning("Could not open .glimpse_filenames.");
<           return;
<       }
<       print("<hr>\n");
<       $sourceroot = $config->sourceroot;
<       while($file = <FILELLISTING>) {
<           $file =~ s/^$sourceroot//;
<           if($file =~ /$searchtext/) {
<               print(&fileref("$file", "find-file",
"/$file"),"<br>\n");
<           }
<       }
---
> # Modification to do file search without glimpse
>       my @files = $index->getallfiles($release);
>       my $file;
>       my $refs='';
>       my $count=0;
>       while ($file = shift(@files)) {
>           if($file =~ /$searchtext/i) {
>               $refs .= &fileref("$file", "find-file", "/$file")."<br>\n";
>               $count++;
>           }
>       }
>       print "<hr>\n";
>       if ($count) {
>               print "Found $count files/directories matching <b>$searchtext</b><br>\n<hr>\n";
>               print $refs;
>       } else {
>               print "No files/directories match <b>$searchtext</b><br>\n";
>       }
--------------------------------------------------------------------------------

The reason I use Perl for matching regexps is that this facility is not
available in
all sorts of databases -  and even if it were, would the regular
expression format
be consistent ?

[Lxr-dev] [ lxr-Bugs-515764 ] lxr 0.9 source brwosing doesn't work for

[<no...@so...>]

Bugs item #515764, was opened at 2002-02-10 22:33
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=515764&group_id=27350

Category: None
Group: None
>Status: Closed
>Resolution: Works For Me
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: lxr 0.9 source brwosing doesn't work for

Initial Comment:
We've tried the standard configuration as in lxr.conf 
to index a non-CVSed source. The indexing seems to 
work (checked up the mysql database for the symbols), 
however browsing the source shows the root-directory 
of the system and does not browse the actual 
sourceroot. Is there something to be done in the 
configuration to make it work? Is there an lxr.conf 
that runs out of the box?


----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2002-02-11 06:28

Message:
Logged In: YES 
user_id=215386

What URL are you looking at when it shows the system root? 
The correct URL should be something like
http://yourdomain/lxr/source to show the sourceroot.

If you want to, you can configure apache to default to this
URL when fed with http://yourdomain/lxr/


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=515764&group_id=27350

[Lxr-dev] [ lxr-Bugs-515764 ] lxr 0.9 source brwosing doesn't work for

[<no...@so...>]

Bugs item #515764, was opened at 2002-02-10 22:33
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=515764&group_id=27350

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: lxr 0.9 source brwosing doesn't work for

Initial Comment:
We've tried the standard configuration as in lxr.conf 
to index a non-CVSed source. The indexing seems to 
work (checked up the mysql database for the symbols), 
however browsing the source shows the root-directory 
of the system and does not browse the actual 
sourceroot. Is there something to be done in the 
configuration to make it work? Is there an lxr.conf 
that runs out of the box?


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=515764&group_id=27350

[Lxr-dev] [ lxr-Bugs-506627 ] Excessive memory usage

[<no...@so...>]

Bugs item #506627, was opened at 2002-01-21 12:48
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=506627&group_id=27350

Category: genxref
Group: current cvs
Status: Closed
Resolution: Fixed
Priority: 4
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Malcolm Box (mbox)
Summary: Excessive memory usage

Initial Comment:
LXR uses much more memory than is required. I have a 
large binary with debugging symbols (80+M) in my 
source tree and attempting to index it I get the 
following error.

Out of memory during "large" request for 134221824 
bytes, total sbrk() is 203704320 bytes at 
lib/LXR/Lang.pm line 42.

Note the first value is equal to 128M. A quick look at 
the source code shows the offending line below:

# Try to see if it's a script
$files->getfile($pathname, $release) =~ /^#!\s*(\S+)/s;

And the offending function from Plain.pm:

sub getfile {
        my ($self, $filename, $release) = @_;
        my ($buffer);
        local ($/) = undef;

        open(FILE, $self->toreal($filename, $release)) 
|| return undef;
        $buffer = <FILE>;
        close(FILE);
        return $buffer;
}

Reading the whole file into memory to determine if it 
is a shell script is really excessive. Surely the 
first line should suffice. File::Type may do a better 
job, but it operates only on a filename, and I'm not 
sure about portability.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2002-02-05 10:30

Message:
Logged In: NO 

I'm using Plain files with Mysql. I'm also running it under 
cygwin. (FYI, I had to disable the copying source files 
to /tmp during the reference phase, since cygwin sometimes 
has problems creating files in /tmp, but this is not 
specific to LXR).

I'd be willing to add some tracing info, but I'm not 
familiar with the Devel::Leak package, so please tell me 
where and what to add.

----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2002-02-05 02:37

Message:
Logged In: YES 
user_id=215386

Hmm, that level of memory usage is strange.  I regularly
index a multi-gigabyte source tree with no memory problems. 
The tree doesn't contain any large binary file, but that
really shouldn't cause any problems.

What setup are you using - CVS/Plain files, Mysql/Postrgres
db?  If you could add some Devel::Leak tracing as well that
would be excellent...

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2002-01-23 10:15

Message:
Logged In: NO 

> Keeping binaries in a source tree is rarely a good thing.

Preaching to the choir...
But the fact of the matter is that large files often do end
up in source trees (trace files, log files, docs ...) just
because it helps for sharing and organization.

Even with this bug fixed, memory usage seems excessive. I
left LXR running for about a day, and found it had slowed to
a crawl because it was swapping constantly. Each perl
process was using about 200 M. It crashed the following day
when it ran out of memory.  I don't know what caused this
yet (I just started it up again).

----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2002-01-22 23:58

Message:
Logged In: YES 
user_id=215386

I suppose one answer would be "Don't do that then" :-) 
Keeping binaries in a source tree is rarely a good thing.

In terms of fixing this, the easiest way would be to use the
Files::getfilehandle rather than Files::getfile to read the
first line.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=506627&group_id=27350

[Lxr-dev] [ lxr-Bugs-512478 ] Fix for Bug 506627 breaks genxref

[<no...@so...>]

Bugs item #512478, was opened at 2002-02-03 13:06
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=512478&group_id=27350

Category: Lang support
>Group: current cvs
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Andrew Beck (andrewbeck)
>Assigned to: Malcolm Box (mbox)
Summary: Fix for Bug 506627 breaks genxref

Initial Comment:
I believe that the fix for Bug 506627 breaks genxref 
when trying to index a broken link. Genxref 0.9 worked 
fine but when I updated LXR to the development version 
on 31/01/2002 it now no longer works on a broken sym 
link.
When genxref tries to index the broken sym link it 
exits with the following error:

Can't call method "getline" on an undefined value at 
LXR/Lang.pm line 44.

I believe this is because line 43 of Lang.pm does not 
check that getfilehandle returns a valid file handle.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=512478&group_id=27350

[Lxr-dev] [ lxr-Bugs-506627 ] Excessive memory usage

[<no...@so...>]

Bugs item #506627, was opened at 2002-01-21 12:48
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=506627&group_id=27350

Category: genxref
Group: current cvs
Status: Closed
Resolution: Fixed
Priority: 4
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Malcolm Box (mbox)
Summary: Excessive memory usage

Initial Comment:
LXR uses much more memory than is required. I have a 
large binary with debugging symbols (80+M) in my 
source tree and attempting to index it I get the 
following error.

Out of memory during "large" request for 134221824 
bytes, total sbrk() is 203704320 bytes at 
lib/LXR/Lang.pm line 42.

Note the first value is equal to 128M. A quick look at 
the source code shows the offending line below:

# Try to see if it's a script
$files->getfile($pathname, $release) =~ /^#!\s*(\S+)/s;

And the offending function from Plain.pm:

sub getfile {
        my ($self, $filename, $release) = @_;
        my ($buffer);
        local ($/) = undef;

        open(FILE, $self->toreal($filename, $release)) 
|| return undef;
        $buffer = <FILE>;
        close(FILE);
        return $buffer;
}

Reading the whole file into memory to determine if it 
is a shell script is really excessive. Surely the 
first line should suffice. File::Type may do a better 
job, but it operates only on a filename, and I'm not 
sure about portability.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2002-02-05 02:37

Message:
Logged In: YES 
user_id=215386

Hmm, that level of memory usage is strange.  I regularly
index a multi-gigabyte source tree with no memory problems. 
The tree doesn't contain any large binary file, but that
really shouldn't cause any problems.

What setup are you using - CVS/Plain files, Mysql/Postrgres
db?  If you could add some Devel::Leak tracing as well that
would be excellent...

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2002-01-23 10:15

Message:
Logged In: NO 

> Keeping binaries in a source tree is rarely a good thing.

Preaching to the choir...
But the fact of the matter is that large files often do end
up in source trees (trace files, log files, docs ...) just
because it helps for sharing and organization.

Even with this bug fixed, memory usage seems excessive. I
left LXR running for about a day, and found it had slowed to
a crawl because it was swapping constantly. Each perl
process was using about 200 M. It crashed the following day
when it ran out of memory.  I don't know what caused this
yet (I just started it up again).

----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2002-01-22 23:58

Message:
Logged In: YES 
user_id=215386

I suppose one answer would be "Don't do that then" :-) 
Keeping binaries in a source tree is rarely a good thing.

In terms of fixing this, the easiest way would be to use the
Files::getfilehandle rather than Files::getfile to read the
first line.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=506627&group_id=27350

Re: [Lxr-dev] dbi string bother.

[Malcolm B. <ma...@br...>]

Christian Robottom Reis wrote:
> 
> One problem that many installers have discussed is the fact that the dbi
> string is just too sensitive - if it doesnt match the exact case or the
> string check we do, the DBI.pm check will bomb out without a warning
> message. We should both provide example strings in lxr.conf (have to look
> at CVS) and allow case-insensitive matching as it seems DBI doesn't care.

Yes, this has bitten me a few times.  We need to improve it.

> Is this fixed in CVS?
> I have a patch for this if it's welcome.

Not fixed in CVS - a patch would be welcome.

Malcolm

Re: [Lxr-dev] Problem with glimpse and CVS

[Malcolm B. <ma...@br...>]

Christian Robottom Reis wrote:
>
> How would you advise the fix to be done? I've added a $glimpsedatadir
> variable and used that as a prefix for the glimpse files, but I'm not sure
> if you agree with that approach. If so, patch in hand.

Well, the very best approach would be to do what the new swish-e code
does, and retrieve the file via the Files interface for display.  This
would then automatically work with CVS, plain and any other file backend
created.

I'm not sure how easy that will be to do - I know glimpse by default
wants to go and actually grep through the files to find exact line
numbers, and you may not want to give that functionality up.  In which
case, the glimpsedatadir solution is probably the best (though you then
have to ask "why not use Plain.pm anyway, since you've got a fully
checked-out tree?).

> Should I be using CVS?

Patches against CVS are usually easier for me to apply, but against a
known revision is also OK.

Regards,

Malcolm

[Lxr-dev] [ lxr-Bugs-512478 ] Fix for Bug 506627 breaks genxref

[<no...@so...>]

Bugs item #512478, was opened at 2002-02-03 13:06
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=512478&group_id=27350

Category: Lang support
Group: v2-dev
Status: Open
Resolution: None
Priority: 5
Submitted By: Andrew Beck (andrewbeck)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for Bug 506627 breaks genxref

Initial Comment:
I believe that the fix for Bug 506627 breaks genxref 
when trying to index a broken link. Genxref 0.9 worked 
fine but when I updated LXR to the development version 
on 31/01/2002 it now no longer works on a broken sym 
link.
When genxref tries to index the broken sym link it 
exits with the following error:

Can't call method "getline" on an undefined value at 
LXR/Lang.pm line 44.

I believe this is because line 43 of Lang.pm does not 
check that getfilehandle returns a valid file handle.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390117&aid=512478&group_id=27350

[Lxr-dev] dbi string bother.

[Christian R. R. <ki...@as...>]

One problem that many installers have discussed is the fact that the dbi
string is just too sensitive - if it doesnt match the exact case or the
string check we do, the DBI.pm check will bomb out without a warning
message. We should both provide example strings in lxr.conf (have to look
at CVS) and allow case-insensitive matching as it seems DBI doesn't care.

Is this fixed in CVS?

I have a patch for this if it's welcome.

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL

Re: [Lxr-dev] Problem with glimpse and CVS

[Christian R. R. <ki...@as...>]

On Sun, 3 Feb 2002, Malcolm Box wrote:

> Patches to fix the glimpse problem are of course still welcome.

How would you advise the fix to be done? I've added a $glimpsedatadir
variable and used that as a prefix for the glimpse files, but I'm not sure
if you agree with that approach. If so, patch in hand.

Should I be using CVS?

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL

Re: [Lxr-dev] Problem with glimpse and CVS

[Malcolm B. <ma...@br...>]

Christian Robottom Reis wrote:
> 
> There is a bug with CVS-enabled lxr and CVS. The gist of the problem is
> the that sourceroot is also used to look for the glimpse files. I've
> hacked lxr to use a glimpsesourceroot variable in my installation.
> 
> Is this fixed in CVS? If it is, I think it's time I checked out CVS lxr

No, this is not fixed in CVS yet.  However, the CVS version does have
swish-e support which removes the need for glimpse and thus solves the
problem, though this is experimental.

Patches to fix the glimpse problem are of course still welcome.

Cheers,

Malcolm

Re: [Lxr-dev] [ lxr-Bugs-506845 ] missing variable in lxr.conf

[Malcolm B. <ma...@br...>]

Hi Christian,

Christian Robottom Reis wrote:
> 
> Thanks. Please note that the fact that 0.9 has a broken lxr.conf has been
> a major issue for many installations, including gnome.org and oeone.com
> as well as my work for mozilla.org. Perhaps the tarball could include that
> file (without changing anything else) if another release is far-off?

Another release is not far off, though I cannot guarantee that the next
release will be any more problem free than 0.9!  If this sort of thing
is a major problem for various installations, perhaps we should talk
about how to make things easier for them.  Obviously I'm keen to have
places like gnome.org using the latest lxr, but I wasn't aware that
these sites were even thinking about deploying recent lxr versions.

> I'm discussing a re-merge with the other mozilla webtools hackers.
 
Excellent, let me know if there's things we can do to make lxr fit in
well.

Malcolm

[Lxr-dev] Re: [Lxr-general] Fortran again

[Malcolm B. <ma...@br...>]

Hi,

Alexander Schuettelkopf wrote:
> 
> Hi,
> 
> I am trying to get some Fortran support into LXR (like so many others,
> seemingly), but due to some surprising and annoying properties of the
> language (I'm not a Fortran programmer myself) it is
> inefficient/hard/impossible to do with LXR::Lang::Generic. So I thought
> I'd just derive a new Lang class and write my own parser, but one of the
> routines I most definitely need to override is &LXR::SimpleParse::nextfrag.
> Now I could either write some really ugly code with lots of "if (... eq
> 'Fortran')" _or_ duplicate the whole generic.conf mechanism for
> SimpleParse or move all of SimpleParse into Lang::Generic (which I would
> prefer). My question is: is there any good reason why the SimpleParse
> routines are in a module of their own. 

I suspect the location of the SimpleParse routines is merely an
implementation artifact.   Originally SimpleParse had no dependancy on
the type of the file.  What is it about Fortran that causes problems for
nextfrag?

> Given their dependency on data
> from generic.conf etc I would have thought it most sensible to move them
> into Lang::Generic as two additional methods. If a derived class wants
> to use the Generic mechanisms it automatically has the parser routines
> that go with it, whereas if it doesn't it can simply overload them...
> Does this make any sense? Of course I had also hoped that, once I got my
> Fortran parser working, I could submit it, so I'd prefer to be as
> compatible with the _real_ LXR as possible.

There seems no good reason that I can think of that this would not
work.  I'd like to see Fortran working - it seems to be something that
many are interested in as you say.

<snip problem re tmpfiles>

> Do I have to respectively am I allowed to file a bug report for this? I apologise if this should have gone to the -dev list. Is that one open for uninvited posting?

Feel free to file a bug report on Sourceforge - anyone can and all are
welcome to.  I'll probably remember to apply this patch, but a bug
report helps prod my memory!  The dev list is also open to any who wish
to participate, though you must be a subscriber to post.

Cheers,

Malcolm

[Lxr-dev] Problem with glimpse and CVS

[Christian R. R. <ki...@as...>]

There is a bug with CVS-enabled lxr and CVS. The gist of the problem is
the that sourceroot is also used to look for the glimpse files. I've
hacked lxr to use a glimpsesourceroot variable in my installation.

Is this fixed in CVS? If it is, I think it's time I checked out CVS lxr
:-)

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL

Re: [Lxr-dev] [ lxr-Bugs-506845 ] missing variable in lxr.conf

[Christian R. R. <ki...@as...>]

On Wed, 30 Jan 2002, Malcolm Box wrote:

> Check the latest version from CVS - this has many of the problems people
> have mentioned addressed, as well as fuller explanations of what the
> various values do/mean.  If once you've looked at it you think you can
> improve it further then please do - I'd like LXR to be as easy to
> install as possible.

Thanks. Please note that the fact that 0.9 has a broken lxr.conf has been
a major issue for many installations, including gnome.org and oeone.com
as well as my work for mozilla.org. Perhaps the tarball could include that
file (without changing anything else) if another release is far-off?

I'm discussing a re-merge with the other mozilla webtools hackers.

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL

[Lxr-dev] [ lxr-Feature Requests-510990 ] Don't require glimpse for file search

[<no...@so...>]

Feature Requests item #510990, was opened at 2002-01-30 16:27
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390120&aid=510990&group_id=27350

Category: General
Group: Next Release
Status: Open
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Don't require glimpse for file search

Initial Comment:
Since you already have the filenames from the 
database, you don't need glimpse for the file name 
search.

Instead you can just run a SQL query like:
select filename from files where filename like \
'%file%';

Which is equivalent to running glimpseindex on 'file'. 
Works in mysql, not sure about Postgres.

'_' is also equivalent to '.' in glimpse for match any 
character. It's not quite full regexp support, but 
it's better than nothing, especially when glimpse is 
not an option.




----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=390120&aid=510990&group_id=27350

Re: [Lxr-dev] [ lxr-Bugs-506845 ] missing variable in lxr.conf

[Malcolm B. <ma...@br...>]

Christian Robottom Reis wrote:

>There are a lot of problems with the stock lxr.conf file sent out. I am
>planning on creating a new template to make installation easier; is this
>being done already or should I contribute?
>
Check the latest version from CVS - this has many of the problems people 
have mentioned addressed, as well as fuller explanations of what the 
various values do/mean.  If once you've looked at it you think you can 
improve it further then please do - I'd like LXR to be as easy to 
install as possible.

Malcolm

Re: [Lxr-dev] [ lxr-Bugs-506845 ] missing variable in lxr.conf

[Christian R. R. <ki...@as...>]

On Wed, 23 Jan 2002 no...@so... wrote:

> I am using lxr in plain file mode, mysql as database.
> When I enabled glimpse support in configuration found that is
> missing variable "dbdir" in lxr.conf file.  So find and search

There are a lot of problems with the stock lxr.conf file sent out. I am
planning on creating a new template to make installation easier; is this
being done already or should I contribute?

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL

Re: [Lxr-dev] ./linux/Rules.make

[Christian R. R. <ki...@as...>]

On Thu, 24 Jan 2002, Jan-Benedict Glaw wrote:

> So I vote to daa "*.make" as a file name pattern to make's definition
> in lxr.conf. I don't know whether or not this is right, but here's a
> patch...

This sounds good to me, as I doubt we will have files that end in *.make
that arent makefiles.

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL

[Lxr-dev] Indexing old kernel source trees

[Jan-Benedict G. <jb...@lu...>]

Hi!

Older linux kernel trees don't have an /include/asm-${ARCH}/
directory which leads to failed lookups for asm/xxx.h files.

I created a "noarch" entry (while updating the architecture list)
and a mapping from '/include/asm-noarch/' to '/include/asm/'.

Please apply!

MfG, JBG
PS: WTF are these mappings processed from bottom to top?


Index: templates/lxr.conf
===================================================================
RCS file: /cvsroot/lxr/lxr/templates/lxr.conf,v
retrieving revision 1.8
diff -u -r1.8 lxr.conf
--- templates/lxr.conf	2002/01/23 15:52:51	1.8
+++ templates/lxr.conf	2002/01/24 22:21:12
@@ -55,11 +55,13 @@
 	 
 					 # Define typed variable "a".  First value is default.
 					 'a' => {'name'    => 'Architecture',
-							 'range'   => [qw(i386 alpha arm m68k mips ppc sparc sparc64)]},
+							 'range'   => [qw(alpha arm cris i386 ia64 m68k mips mips64 parisc ppc s390 s390x sh sparc sparc64 noarch)],
+							 'default'	=> 'i386'},
 					},
 
   # These do funky things to paths in the system - you probably don't need them.
   'maps' => {
+			 '/include/asm-noarch/'  => '/include/asm/',
 			 '/include/asm[^\/]*/' => '/include/asm-$a/',
 			 '/arch/[^\/]+/'       => '/arch/$a/',
 			},
@@ -150,7 +152,7 @@
 # 				 ['Lisp', '(?i)\.cl$|\.clisp$|\.el$|\.l$|\.lisp$|\.lsp$|\.ml$'   #'
  # 				  , 'LXR::Lang::Generic'],
                   # No tabwidth specified here as an example
- 				 'Make' => ['Make', '(?i)\.mak$|makefile*' #'
+ 				 'Make' => ['Make', '(?i)\.mak$|makefile*|(?i)\.make' #'
 							, 'LXR::Lang::Generic'],
 # 				 ['Pascal', '(?i)\.p$|\.pas$'   #'
 # 				  , 'LXR::Lang::Generic'],
-- 
Jan-Benedict Glaw   .   jb...@lu...   .   +49-172-7608481
	 -- New APT-Proxy written in shell script --
	   http://lug-owl.de/~jbglaw/software/ap2/

[Lxr-dev] ./linux/Rules.make

[Jan-Benedict G. <jb...@lu...>]

Hi!

Currently, ./linux/Rules.make isn't indexed because it neither ends up
in ".mak", nor does it contain a shell^Wmake bang.

So I vote to daa "*.make" as a file name pattern to make's definition
in lxr.conf. I don't know whether or not this is right, but here's a
patch...

Index: templates/lxr.conf
===================================================================
RCS file: /cvsroot/lxr/lxr/templates/lxr.conf,v
retrieving revision 1.8
diff -u -r1.8 lxr.conf
--- templates/lxr.conf	2002/01/23 15:52:51	1.8
+++ templates/lxr.conf	2002/01/24 09:21:17
@@ -150,7 +150,7 @@
 # 				 ['Lisp', '(?i)\.cl$|\.clisp$|\.el$|\.l$|\.lisp$|\.lsp$|\.ml$'   #'
  # 				  , 'LXR::Lang::Generic'],
                   # No tabwidth specified here as an example
- 				 'Make' => ['Make', '(?i)\.mak$|makefile*' #'
+ 				 'Make' => ['Make', '(?i)\.mak$|makefile*|(?i)\.make' #'
 							, 'LXR::Lang::Generic'],
 # 				 ['Pascal', '(?i)\.p$|\.pas$'   #'
 # 				  , 'LXR::Lang::Generic'],
 
 
 
 
MfG, JBG

-- 
Jan-Benedict Glaw   .   jb...@lu...   .   +49-172-7608481
	 -- New APT-Proxy written in shell script --
	   http://lug-owl.de/~jbglaw/software/ap2/