lxr-developer — Don't use, active developers only

[Lxr-dev] [ lxr-Bugs-2787771 ] Index::fileindexed and Index::filereferenced are inverted

[SourceForge.net <no...@so...>]

Bugs item #2787771, was opened at 2009-05-06 11:12
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787771&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Malcolm Box (mbox)
Summary: Index::fileindexed and Index::filereferenced are inverted

Initial Comment:
The functions Index::filereferenced and Index::fileindexed are documented to return true if the file is already indexed/referenced, however the code actually returns true if the file NEEDS to be indexed or referenced i.e. the inverse of the documented behaviour, and this is the behaviour that genxref relies on.

Suggested fix is to change the code to match the documentation

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2009-05-12 16:57

Message:
Fixed as suggested

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787771&group_id=27350

[Lxr-dev] [ lxr-Bugs-2787781 ] Mysql & Postgres versions of functions differ

[SourceForge.net <no...@so...>]

Bugs item #2787781, was opened at 2009-05-06 11:44
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787781&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: AdrianIssott (adrianissott)
Summary: Mysql & Postgres versions of functions differ

Initial Comment:
The Mysql.pm and Postgres.pm versions of fileindexed and filereferenced differ - the Postgres version has a side-effect of setting the indexed/referenced property to true when it is called, whereas the Mysql version doesn't.

The Mysql version is correct, as the database should only be updated to show indexed/referenced once the process has completed, which is what Tagger.pm does.

Fix is to change the Postgres version to not have a side effect.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2009-05-12 16:56

Message:
Fixed by latest changes from Adrian

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787781&group_id=27350

[Lxr-dev] [ lxr-Bugs-2787809 ] Weird ordering dependencies in Index implementations

[SourceForge.net <no...@so...>]

Bugs item #2787809, was opened at 2009-05-06 12:48
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787809&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Malcolm Box (mbox)
Summary: Weird ordering dependencies in Index implementations

Initial Comment:
The mysql.pm implementations of fileindexed/filereferenced & setfileindexed/setfilereferenced have a weird ordering requirement that the getter must be called before the setter will work, as the setter only does an UPDATE on the database, not an INSERT.  The INSERT is only performed by the getter.

While this works in practise because Tagger.pm always checks the status before setting, it is rather unnatural and should be removed.  The cost will be an extra SELECT against the database to establish whether the file is already listed - this is very low cost compared to other db operations going on for each file being indexed/referenced.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2009-05-12 16:55

Message:
Fixed by latest updates to the DB code

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787809&group_id=27350

Re: [Lxr-dev] FW: [Lxr-commits] CVS: lxr/lib/LXR/Index Mysql.pm, 1.30, 1.31 Oracle.pm, 1.20, 1.21 DB.pm, 1.17, 1.18 Postgres.pm, 1.31, 1.32

[Malcolm B. <mal...@gm...>]

Hi,

On Sun, May 10, 2009 at 1:02 PM, Adrian Issott <adr...@ho...> wrote:
>
> I felt that rel wasn't as immediately
> understandable as releaseid so I changed all the columns to that. While
> doing a search and replace it struck me that the code would be cleaner if
> all the $release variables were renamed to $releaseid too to match up with
> the SQL so I've also done that which meant a whole lot of files have changed
> superficially.

releaseid is a better name - so this change looks fine to me.

>
> BTW, when we release v0.9.6, as result of the fix for bug 1209273, we're
> going to need to tell people that their existing databases won't work
> out-of-the-box with the new version ...

Yes, must remember to flag that up in the release notes and
announcement.  We've broken db compatibility in the past without
anyone complaining, so I guess it will be OK.

I suppose for extra points we could provide a migration script, but my
preference would be to only do that for stable versions (i.e. 1.0
onwards).

Malcolm

[Lxr-dev] FW: [Lxr-commits] CVS: lxr/lib/LXR/Index Mysql.pm, 1.30, 1.31 Oracle.pm, 1.20, 1.21 DB.pm, 1.17, 1.18 Postgres.pm, 1.31, 1.32

[Adrian I. <adr...@ho...>]

Hi All,

I've just made a commit that probably needs a bit more than normal explanation. The issue I set out to solve was to further standarise the SQL used by each of the DBI implementations; in particular to use the same column names in the lxr_releases table. Malcolm correctly fixed bug 1209273 (release a reserved word in MySQL 5.x) just after v0.9.5 of lxr was released by changing the release column to be the rel column. However, this was done just for MySql so something similar needed to be done for the Postgres and Oracle implementations too. I felt that rel wasn't as immediately understandable as releaseid so I changed all the columns to that. While doing a search and replace it struck me that the code would be cleaner if all the $release variables were renamed to $releaseid too to match up with the SQL so I've also done that which meant a whole lot of files have changed superficially. 

Anyhow, if you don't like the new name, feel free to suggest an alternative and I'd be happy to make the changes.

Cheers,
Adrian

BTW, when we release v0.9.6, as result of the fix for bug 1209273, we're going to need to tell people that their existing databases won't work out-of-the-box with the new version ...

> From: adr...@us...
> Date: Sun, 10 May 2009 11:54:31 +0000
> To: lxr...@li...
> Subject: [Lxr-commits] CVS: lxr/lib/LXR/Index Mysql.pm, 1.30, 1.31 Oracle.pm,	1.20, 1.21 DB.pm, 1.17, 1.18 Postgres.pm, 1.31, 1.32
> 
> Update of /cvsroot/lxr/lxr/lib/LXR/Index
> In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv3821/lib/LXR/Index
> 
> Modified Files:
> 	Mysql.pm Oracle.pm DB.pm Postgres.pm 
> Log Message:
> Feature 1691378 (Rearchitect the DB backends) Part X
> * Renamed lxr_release.rel -> releaseid for Mysql
> * Renamed lxr_release.release -> releaseid for Oracle and Postgres
> * Renamed $release -> $releaseid generally
> 
> Index: Mysql.pm
> ===================================================================
> RCS file: /cvsroot/lxr/lxr/lib/LXR/Index/Mysql.pm,v
> retrieving revision 1.30
> retrieving revision 1.31
> diff -u -d -r1.30 -r1.31
> --- Mysql.pm	9 May 2009 21:57:34 -0000	1.30
> +++ Mysql.pm	10 May 2009 11:54:29 -0000	1.31
> @@ -73,7 +73,7 @@
>            . "where s.symid = i.symid and i.fileid = f.fileid "
>            . "and f.fileid = r.fileid "
>            . "and i.langid = d.langid and i.type = d.declid "
> -          . "and s.symname = ? and r.rel = ? "
> +          . "and s.symname = ? and r.releaseid = ? "
>            . "order by f.filename, i.line, d.declaration");
>      $self->{indexes_insert} =
>        $self->{dbh}->prepare(
> @@ -81,9 +81,9 @@
>        );
>  
>      $self->{releases_select} =
> -      $self->{dbh}->prepare("select * from ${prefix}releases where fileid = ? and  rel = ?");
> +      $self->{dbh}->prepare("select * from ${prefix}releases where fileid = ? and  releaseid = ?");
>      $self->{releases_insert} =
> -      $self->{dbh}->prepare("insert into ${prefix}releases (fileid, rel) values (?, ?)");
> +      $self->{dbh}->prepare("insert into ${prefix}releases (fileid, releaseid) values (?, ?)");
>  
>      $self->{status_select} =
>        $self->{dbh}->prepare("select status from ${prefix}status where fileid = ?");
> @@ -100,7 +100,7 @@
>            . "where s.symid = u.symid "
>            . "and f.fileid = u.fileid "
>            . "and u.fileid = r.fileid "
> -          . "and s.symname = ? and  r.rel = ? "
> +          . "and s.symname = ? and  r.releaseid = ? "
>            . "order by f.filename, u.line");
>      $self->{decl_select} =
>        $self->{dbh}->prepare(
> @@ -113,24 +113,24 @@
>        $self->{dbh}->prepare("delete from i "
>            . "using ${prefix}indexes i, ${prefix}releases r "
>            . "where i.fileid = r.fileid "
> -          . "and r.rel = ?");
> +          . "and r.releaseid = ?");
>      $self->{delete_usage} =
>        $self->{dbh}->prepare("delete from u "
>            . "using ${prefix}usage u, ${prefix}releases r "
>            . "where u.fileid = r.fileid "
> -          . "and r.rel = ?");
> +          . "and r.releaseid = ?");
>      $self->{delete_status} =
>        $self->{dbh}->prepare("delete from s "
>            . "using ${prefix}status s, ${prefix}releases r "
>            . "where s.fileid = r.fileid "
> -          . "and r.rel = ?");
> +          . "and r.releaseid = ?");
>      $self->{delete_releases} =
> -      $self->{dbh}->prepare("delete from ${prefix}releases where rel = ?");
> +      $self->{dbh}->prepare("delete from ${prefix}releases where releaseid = ?");
>      $self->{delete_files} =
>        $self->{dbh}->prepare("delete from f "
>            . "using ${prefix}files f, ${prefix}releases r "
>            . "where f.fileid = r.fileid "
> -          . "and r.rel = ?");
> +          . "and r.releaseid = ?");
>  
>      return $self;
>  }
> @@ -185,13 +185,13 @@
>  }
>  
>  sub setfilerelease {
> -    my ($self, $fileid, $release) = @_;
> +    my ($self, $fileid, $releaseid) = @_;
>  
> -    my $rows = $self->{releases_select}->execute($fileid + 0, $release);
> +    my $rows = $self->{releases_select}->execute($fileid + 0, $releaseid);
>      $self->{releases_select}->finish();
>  
>      unless ($rows > 0) {
> -        $self->{releases_insert}->execute($fileid, $release);
> +        $self->{releases_insert}->execute($fileid, $releaseid);
>      }
>  }
>  
> @@ -251,10 +251,10 @@
>  }
>  
>  sub symdeclarations {
> -    my ($self, $symname, $release) = @_;
> +    my ($self, $symname, $releaseid) = @_;
>      my ($rows, @ret, @row);
>  
> -    $rows = $self->{indexes_select}->execute("$symname", "$release");
> +    $rows = $self->{indexes_select}->execute("$symname", "$releaseid");
>      while (@row = $self->{indexes_select}->fetchrow_array) {
>          $row[3] &&= $self->symname($row[3]); # convert the symid
>          push(@ret, [@row]);
> @@ -272,10 +272,10 @@
>  }
>  
>  sub symreferences {
> -    my ($self, $symname, $release) = @_;
> +    my ($self, $symname, $releaseid) = @_;
>      my ($rows, @ret, @row);
>  
> -    $rows = $self->{usage_select}->execute("$symname", "$release");
> +    $rows = $self->{usage_select}->execute("$symname", "$releaseid");
>  
>      while (@row = $self->{usage_select}->fetchrow_array) {
>          push(@ret, [@row]);
> @@ -293,15 +293,15 @@
>  }
>  
>  sub issymbol {
> -    my ($self, $symname, $release) = @_; # TODO make full use of $release
> +    my ($self, $symname, $releaseid) = @_; # TODO make full use of $releaseid
>      my ($symid);
>  
> -    $symid = $symcache{$release}{$symname};
> +    $symid = $symcache{$releaseid}{$symname};
>      unless (defined($symid)) {
>          $self->{symbols_byname}->execute($symname);
>          ($symid) = $self->{symbols_byname}->fetchrow_array();
>          $self->{symbols_byname}->finish();
> -        $symcache{$release}{$symname} = $symid;
> +        $symcache{$releaseid}{$symname} = $symid;
>      }
>  
>      return $symid;
> @@ -363,15 +363,15 @@
>  }
>  
>  sub purge {
> -    my ($self, $release) = @_;
> +    my ($self, $releaseid) = @_;
>  
>      # we don't delete symbols, because they might be used by other versions
>      # so we can end up with unused symbols, but that doesn't cause any problems
> -    $self->{delete_indexes}->execute($release);
> -    $self->{delete_usage}->execute($release);
> -    $self->{delete_status}->execute($release);
> -    $self->{delete_releases}->execute($release);
> -    $self->{delete_files}->execute($release);
> +    $self->{delete_indexes}->execute($releaseid);
> +    $self->{delete_usage}->execute($releaseid);
> +    $self->{delete_status}->execute($releaseid);
> +    $self->{delete_releases}->execute($releaseid);
> +    $self->{delete_files}->execute($releaseid);
>  }
>  
>  1;
> 
> Index: Oracle.pm
> ===================================================================
> RCS file: /cvsroot/lxr/lxr/lib/LXR/Index/Oracle.pm,v
> retrieving revision 1.20
> retrieving revision 1.21
> diff -u -d -r1.20 -r1.21
> --- Oracle.pm	9 May 2009 21:57:34 -0000	1.20
> +++ Oracle.pm	10 May 2009 11:54:29 -0000	1.21
> @@ -71,7 +71,7 @@
>            . "where s.symid = i.symid and i.fileid = f.fileid "
>            . "and f.fileid = r.fileid "
>            . "and i.langid = d.langid and i.type = d.declid "
> -          . "and s.symname = ? and r.release = ? "
> +          . "and s.symname = ? and r.releaseid = ? "
>            . "order by f.filename, i.line, d.declaration");
>      $self->{indexes_insert} =
>        $self->{dbh}->prepare(
> @@ -79,9 +79,9 @@
>        );
>  
>      $self->{releases_select} =
> -      $self->{dbh}->prepare("select * from ${prefix}releases where fileid = ? and  release = ?");
> +      $self->{dbh}->prepare("select * from ${prefix}releases where fileid = ? and  releaseid = ?");
>      $self->{releases_insert} =
> -      $self->{dbh}->prepare("insert into ${prefix}releases (fileid, release) values (?, ?)");
> +      $self->{dbh}->prepare("insert into ${prefix}releases (fileid, releaseid) values (?, ?)");
>  
>      $self->{status_select} =
>        $self->{dbh}->prepare("select status from ${prefix}status where fileid = ?");
> @@ -100,7 +100,7 @@
>            . "where s.symid = u.symid "
>            . "and f.fileid = u.fileid "
>            . "and u.fileid = r.fileid "
> -          . "and s.symname = ? and  r.release = ? "
> +          . "and s.symname = ? and  r.releaseid = ? "
>            . "order by f.filename, u.line");
>      $self->{decl_select} =
>        $self->{dbh}->prepare(
> @@ -112,21 +112,21 @@
>      $self->{delete_indexes} =
>        $self->{dbh}->prepare("delete from ${prefix}indexes "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>      $self->{delete_usage} =
>        $self->{dbh}->prepare("delete from ${prefix}usage "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>      $self->{delete_status} =
>        $self->{dbh}->prepare("delete from ${prefix}status "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>      $self->{delete_releases} =
> -      $self->{dbh}->prepare("delete from ${prefix}releases where release = ?");
> +      $self->{dbh}->prepare("delete from ${prefix}releases where releaseid = ?");
>      $self->{delete_files} =
>        $self->{dbh}->prepare("delete from ${prefix}files "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>  
>      return $self;
>  }
> @@ -181,13 +181,13 @@
>  }
>  
>  sub setfilerelease {
> -    my ($self, $fileid, $release) = @_;
> +    my ($self, $fileid, $releaseid) = @_;
>  
> -    my $rows = $self->{releases_select}->execute($fileid + 0, $release);
> +    my $rows = $self->{releases_select}->execute($fileid + 0, $releaseid);
>      $self->{releases_select}->finish();
>  
>      unless ($rows > 0) {
> -        $self->{releases_insert}->execute($fileid, $release);
> +        $self->{releases_insert}->execute($fileid, $releaseid);
>      }
>  }
>  
> @@ -247,10 +247,10 @@
>  }
>  
>  sub symdeclarations {
> -    my ($self, $symname, $release) = @_;
> +    my ($self, $symname, $releaseid) = @_;
>      my ($rows, @ret, @row);
>  
> -    $rows = $self->{indexes_select}->execute("$symname", "$release");
> +    $rows = $self->{indexes_select}->execute("$symname", "$releaseid");
>      while (@row = $self->{indexes_select}->fetchrow_array) {
>          $row[3] &&= $self->symname($row[3]); # convert the symid
>          push(@ret, [@row]);
> @@ -268,10 +268,10 @@
>  }
>  
>  sub symreferences {
> -    my ($self, $symname, $release) = @_;
> +    my ($self, $symname, $releaseid) = @_;
>      my ($rows, @ret, @row);
>  
> -    $rows = $self->{usage_select}->execute("$symname", "$release");
> +    $rows = $self->{usage_select}->execute("$symname", "$releaseid");
>  
>      while (@row = $self->{usage_select}->fetchrow_array) {
>          push(@ret, [@row]);
> @@ -289,15 +289,15 @@
>  }
>  
>  sub issymbol {
> -    my ($self, $symname, $release) = @_; # TODO make full use of $release
> +    my ($self, $symname, $releaseid) = @_; # TODO make full use of $releaseid
>      my ($symid);
>  
> -    $symid = $symcache{$release}{$symname};
> +    $symid = $symcache{$releaseid}{$symname};
>      unless (defined($symid)) {
>          $self->{symbols_byname}->execute($symname);
>          ($symid) = $self->{symbols_byname}->fetchrow_array();
>          $self->{symbols_byname}->finish();
> -        $symcache{$release}{$symname} = $symid;
> +        $symcache{$releaseid}{$symname} = $symid;
>      }
>  
>      return $symid;
> @@ -359,15 +359,15 @@
>  }
>  
>  sub purge {
> -    my ($self, $release) = @_;
> +    my ($self, $releaseid) = @_;
>  
>      # we don't delete symbols, because they might be used by other versions
>      # so we can end up with unused symbols, but that doesn't cause any problems
> -    $self->{delete_indexes}->execute($release);
> -    $self->{delete_usage}->execute($release);
> -    $self->{delete_status}->execute($release);
> -    $self->{delete_releases}->execute($release);
> -    $self->{delete_files}->execute($release);
> +    $self->{delete_indexes}->execute($releaseid);
> +    $self->{delete_usage}->execute($releaseid);
> +    $self->{delete_status}->execute($releaseid);
> +    $self->{delete_releases}->execute($releaseid);
> +    $self->{delete_files}->execute($releaseid);
>  }
>  
>  1;
> 
> Index: DB.pm
> ===================================================================
> RCS file: /cvsroot/lxr/lxr/lib/LXR/Index/DB.pm,v
> retrieving revision 1.17
> retrieving revision 1.18
> diff -u -d -r1.17 -r1.18
> --- DB.pm	9 May 2009 21:57:34 -0000	1.17
> +++ DB.pm	10 May 2009 11:54:29 -0000	1.18
> @@ -54,14 +54,14 @@
>  
>  # Returns array of (fileid, line, type)
>  sub symdeclarations {
> -	my ($self, $symname, $release) = @_;
> +	my ($self, $symname, $releaseid) = @_;
>  
>  	my (@d, $f);
>  	foreach $f (split(/\0/, $$self{'indexes'}{ $self->symid($symname) })) {
>  		my ($fi, $l, $t, $s) = split(/\t/, $f);
>  
>  		my %r = map { ($_ => 1) } split(/;/, $self->{'releases'}{$fi});
> -		next unless $r{$release};
> +		next unless $r{$releaseid};
>  
>  		push(@d, [ $self->filename($fi), $l, $t, $s ]);
>  	}
> @@ -69,7 +69,7 @@
>  }
>  
>  sub symreferences {
> -  my ($self, $symname, $release) = @_;
> +  my ($self, $symname, $releaseid) = @_;
>  	return ();
>  }
>  
> @@ -98,11 +98,11 @@
>  	return 1;
>  }
>  
> -# Indicate that this filerevision is part of this release
> +# Indicate that this filerevision is part of this releaseid
>  sub setfilerelease {
> -	my ($self, $fileid, $release) = @_;
> +	my ($self, $fileid, $releaseid) = @_;
>  
> -	$self->{'releases'}{$fileid} .= $release . ";";
> +	$self->{'releases'}{$fileid} .= $releaseid . ";";
>  }
>  
>  sub symid {
> @@ -113,7 +113,7 @@
>  }
>  
>  sub issymbol {
> -	my ($self, $symname, $release) = @_;
> +	my ($self, $symname, $releaseid) = @_;
>  
>  	return $$self{'indexes'}{ $self->symid($symname) };
>  }
> 
> Index: Postgres.pm
> ===================================================================
> RCS file: /cvsroot/lxr/lxr/lib/LXR/Index/Postgres.pm,v
> retrieving revision 1.31
> retrieving revision 1.32
> diff -u -d -r1.31 -r1.32
> --- Postgres.pm	9 May 2009 21:57:34 -0000	1.31
> +++ Postgres.pm	10 May 2009 11:54:29 -0000	1.32
> @@ -77,14 +77,14 @@
>            . "where s.symid = i.symid and i.fileid = f.fileid "
>            . "and f.fileid = r.fileid "
>            . "and i.langid = d.langid and i.type = d.declid "
> -          . "and s.symname = ? and r.release = ? "
> +          . "and s.symname = ? and r.releaseid = ? "
>            . "order by f.filename, i.line, d.declaration");
>      $self->{indexes_insert} =
>        $self->{dbh}->prepare("insert into ${prefix}indexes (symid, fileid, line, langid, type, relsym) "
>            . "values (?, ?, ?, ?, ?, ?)");
>  
>      $self->{releases_select} =
> -      $self->{dbh}->prepare("select * from ${prefix}releases where fileid = ? and release = ?");
> +      $self->{dbh}->prepare("select * from ${prefix}releases where fileid = ? and releaseid = ?");
>      $self->{releases_insert} =
>        $self->{dbh}->prepare("insert into ${prefix}releases values (?, ?)");
>  
> @@ -103,7 +103,7 @@
>            . "where s.symid = u.symid "
>            . "and f.fileid = u.fileid "
>            . "and u.fileid = r.fileid "
> -          . "and s.symname = ? and  r.release = ? "
> +          . "and s.symname = ? and  r.releaseid = ? "
>            . "order by f.filename, u.line");
>  
>      $self->{declid_nextnum} = 
> @@ -119,21 +119,21 @@
>      $self->{delete_indexes} =
>        $self->{dbh}->prepare("delete from ${prefix}indexes "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>      $self->{delete_usage} =
>        $self->{dbh}->prepare("delete from ${prefix}usage "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>      $self->{delete_status} =
>        $self->{dbh}->prepare("delete from ${prefix}status "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>      $self->{delete_releases} =
> -      $self->{dbh}->prepare("delete from ${prefix}releases where release = ?");
> +      $self->{dbh}->prepare("delete from ${prefix}releases where releaseid = ?");
>      $self->{delete_files} =
>        $self->{dbh}->prepare("delete from ${prefix}files "
>            . "where fileid in "
> -          . "  (select fileid from ${prefix}releases where release = ?)");
> +          . "  (select fileid from ${prefix}releases where releaseid = ?)");
>  
>      return $self;
>  }
> @@ -199,15 +199,15 @@
>  }
>  
>  sub setfilerelease {
> -    my ($self, $fileid, $release) = @_;
> +    my ($self, $fileid, $releaseid) = @_;
>  
> -    $self->{releases_select}->execute($fileid + 0, $release);
> +    $self->{releases_select}->execute($fileid + 0, $releaseid);
>      my $firstrow = $self->{releases_select}->fetchrow_array();
>  
>  #    $self->{releases_select}->finish();
>  
>      unless ($firstrow) {
> -        $self->{releases_insert}->execute($fileid + 0, $release);
> +        $self->{releases_insert}->execute($fileid + 0, $releaseid);
>          $self->_commitIfLimit();
>      }
>  }
> @@ -270,10 +270,10 @@
>  }
>  
>  sub symdeclarations {
> -    my ($self, $symname, $release) = @_;
> +    my ($self, $symname, $releaseid) = @_;
>      my ($rows, @ret, @row);
>  
> -    $rows = $self->{indexes_select }->execute("$symname", "$release");
> +    $rows = $self->{indexes_select }->execute("$symname", "$releaseid");
>  
>      while (@row = $self->{indexes_select }->fetchrow_array) {
>          $row[3] &&= $self->symname($row[3]); # convert the symid
> @@ -298,10 +298,10 @@
>  }
>  
>  sub symreferences {
> -    my ($self, $symname, $release) = @_;
> +    my ($self, $symname, $releaseid) = @_;
>      my ($rows, @ret, @row);
>  
> -    $rows = $self->{usage_select}->execute("$symname", "$release");
> +    $rows = $self->{usage_select}->execute("$symname", "$releaseid");
>  
>      while (@row = $self->{usage_select}->fetchrow_array) {
>          push(@ret, [@row]);
> @@ -320,7 +320,7 @@
>  }
>  
>  sub issymbol {
> -    my ($self, $symname, $release) = @_; # TODO make full use of $release
> +    my ($self, $symname, $releaseid) = @_; # TODO make full use of $releaseid
>  
>      unless (exists($symcache{$symname})) {
>          $self->{symbols_byname}->execute($symname);
> @@ -383,15 +383,15 @@
>  }
>  
>  sub purge {
> -    my ($self, $release) = @_;
> +    my ($self, $releaseid) = @_;
>  
>      # we don't delete symbols, because they might be used by other versions
>      # so we can end up with unused symbols, but that doesn't cause any problems
> -    $self->{delete_indexes}->execute($release);
> -    $self->{delete_usage}->execute($release);
> -    $self->{delete_status}->execute($release);
> -    $self->{delete_releases}->execute($release);
> -    $self->{delete_files}->execute($release);
> +    $self->{delete_indexes}->execute($releaseid);
> +    $self->{delete_usage}->execute($releaseid);
> +    $self->{delete_status}->execute($releaseid);
> +    $self->{delete_releases}->execute($releaseid);
> +    $self->{delete_files}->execute($releaseid);
>  
>      $self->{dbh}->commit() or die "Commit failed: $DBI::errstr";
>      $self->{dbh}->begin_work() or die "begin_work failed: $DBI::errstr";
> 
> 
> ------------------------------------------------------------------------------
> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
> production scanning environment may not be a perfect world - but thanks to
> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
> Series Scanner you'll get full speed at 300 dpi even with all image 
> processing features enabled. http://p.sf.net/sfu/kodak-com
> _______________________________________________
> Lxr-commits mailing list
> Lxr...@li...
> https://lists.sourceforge.net/lists/listinfo/lxr-commits

_________________________________________________________________
View your Twitter and Flickr updates from one place – Learn more!
http://clk.atdmt.com/UKM/go/137984870/direct/01/

[Lxr-dev] [ lxr-Bugs-2789413 ] MysqlTest.pm Doesn't Work on Windows

[SourceForge.net <no...@so...>]

Bugs item #2789413, was opened at 2009-05-09 14:53
Message generated for change (Comment added) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2789413&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: AdrianIssott (adrianissott)
Summary: MysqlTest.pm Doesn't Work on Windows

Initial Comment:
Running the test on windows after correctly setting up MySql results in the following:

.....The system cannot find the path specified.
.The system cannot find the path specified.
.The system cannot find the path specified.
.The system cannot find the path specified.
.The system cannot find the path specified.
F.The system cannot find the path specified.
.The system cannot find the path specified.
F
Time:  1 wallclock secs ( 0.39 usr +  0.06 sys =  0.45 CPU)

!!!FAILURES!!!
Test Results:
Run: 23, Failures: 2, Errors: 0

There were 2 failures:
1) MysqlTest.pm:60 - test_fileindexed(MysqlTest)
expected 0, got 2

2) MysqlTest.pm:47 - test_fileid(MysqlTest)
Wrong number of rows in DB

----------------------------------------------------------------------

>Comment By: AdrianIssott (adrianissott)
Date: 2009-05-09 14:55

Message:
Solution was to use File::Spec to get the null device in an OS independent
way

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2789413&group_id=27350

[Lxr-dev] [ lxr-Bugs-2789413 ] MysqlTest.pm Doesn't Work on Windows

[SourceForge.net <no...@so...>]

Bugs item #2789413, was opened at 2009-05-09 14:53
Message generated for change (Tracker Item Submitted) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2789413&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: AdrianIssott (adrianissott)
Summary: MysqlTest.pm Doesn't Work on Windows

Initial Comment:
Running the test on windows after correctly setting up MySql results in the following:

.....The system cannot find the path specified.
.The system cannot find the path specified.
.The system cannot find the path specified.
.The system cannot find the path specified.
.The system cannot find the path specified.
F.The system cannot find the path specified.
.The system cannot find the path specified.
F
Time:  1 wallclock secs ( 0.39 usr +  0.06 sys =  0.45 CPU)

!!!FAILURES!!!
Test Results:
Run: 23, Failures: 2, Errors: 0

There were 2 failures:
1) MysqlTest.pm:60 - test_fileindexed(MysqlTest)
expected 0, got 2

2) MysqlTest.pm:47 - test_fileid(MysqlTest)
Wrong number of rows in DB

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2789413&group_id=27350

Re: [Lxr-dev] [Lxr-general] Large installations running on Postgres?

[Adrian I. <adr...@ho...>]

Hi Malcolm,

I don't have a sufficiently large code base to test this with but I would be surprised if turning on AutoCommit didn't significantly impact the performance of indexing. My thinking on this was that as part of Feature Request 1691378 (Rearchitect the DB backends) that the LXR::Index::DBI class would define an abstract "TransactionCompleted()" subroutine that derived classes (such as LXR::Index::Postgres) could implement to call commit or not as they choose.

Adrian

> From: mal...@gm...
> Date: Wed, 6 May 2009 22:22:46 +0100
> To: lxr...@li...; lxr...@li...
> Subject: [Lxr-general] Large installations running on Postgres?
> 
> Hi,
> 
> I'm wondering what the performance (dis)advantage is of having
> DBI::AutoCommit switched off for Postgresql.  As part of a general
> tidy-up of the Index classes I'm considering switching AutoCommit to
> on - but I don't have a decent-sized install to check the performance
> impact.
> 
> Has anyone got a large-ish installation running using Postgres who
> could measure the performance with AutoCommit switched on and off -
> the relevant line to change is line 43 in lib/LXR/Index/Postgres.pm.
> 
> Any data would be much appreciated!
> 
> Cheers,
> 
> Malcolm
> 
> ------------------------------------------------------------------------------
> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
> production scanning environment may not be a perfect world - but thanks to
> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
> Series Scanner you'll get full speed at 300 dpi even with all image 
> processing features enabled. http://p.sf.net/sfu/kodak-com
> _______________________________________________
> Lxr-general mailing list
> Lxr...@li...
> https://lists.sourceforge.net/lists/listinfo/lxr-general

_________________________________________________________________
Share your photos with Windows Live Photos – Free.
http://clk.atdmt.com/UKM/go/134665338/direct/01/

[Lxr-dev] Large installations running on Postgres?

[Malcolm B. <mal...@gm...>]

Hi,

I'm wondering what the performance (dis)advantage is of having
DBI::AutoCommit switched off for Postgresql.  As part of a general
tidy-up of the Index classes I'm considering switching AutoCommit to
on - but I don't have a decent-sized install to check the performance
impact.

Has anyone got a large-ish installation running using Postgres who
could measure the performance with AutoCommit switched on and off -
the relevant line to change is line 43 in lib/LXR/Index/Postgres.pm.

Any data would be much appreciated!

Cheers,

Malcolm

[Lxr-dev] [ lxr-Bugs-2787809 ] Weird ordering dependencies in Index implementations

[SourceForge.net <no...@so...>]

Bugs item #2787809, was opened at 2009-05-06 12:48
Message generated for change (Tracker Item Submitted) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787809&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Malcolm Box (mbox)
Summary: Weird ordering dependencies in Index implementations

Initial Comment:
The mysql.pm implementations of fileindexed/filereferenced & setfileindexed/setfilereferenced have a weird ordering requirement that the getter must be called before the setter will work, as the setter only does an UPDATE on the database, not an INSERT.  The INSERT is only performed by the getter.

While this works in practise because Tagger.pm always checks the status before setting, it is rather unnatural and should be removed.  The cost will be an extra SELECT against the database to establish whether the file is already listed - this is very low cost compared to other db operations going on for each file being indexed/referenced.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787809&group_id=27350

[Lxr-dev] [ lxr-Bugs-2787781 ] Mysql & Postgres versions of functions differ

[SourceForge.net <no...@so...>]

Bugs item #2787781, was opened at 2009-05-06 11:44
Message generated for change (Tracker Item Submitted) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787781&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: AdrianIssott (adrianissott)
Summary: Mysql & Postgres versions of functions differ

Initial Comment:
The Mysql.pm and Postgres.pm versions of fileindexed and filereferenced differ - the Postgres version has a side-effect of setting the indexed/referenced property to true when it is called, whereas the Mysql version doesn't.

The Mysql version is correct, as the database should only be updated to show indexed/referenced once the process has completed, which is what Tagger.pm does.

Fix is to change the Postgres version to not have a side effect.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787781&group_id=27350

[Lxr-dev] [ lxr-Bugs-2787771 ] Index::fileindexed and Index::filereferenced are inverted

[SourceForge.net <no...@so...>]

Bugs item #2787771, was opened at 2009-05-06 11:12
Message generated for change (Tracker Item Submitted) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787771&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Malcolm Box (mbox)
Summary: Index::fileindexed and Index::filereferenced are inverted

Initial Comment:
The functions Index::filereferenced and Index::fileindexed are documented to return true if the file is already indexed/referenced, however the code actually returns true if the file NEEDS to be indexed or referenced i.e. the inverse of the documented behaviour, and this is the behaviour that genxref relies on.

Suggested fix is to change the code to match the documentation

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2787771&group_id=27350

[Lxr-dev] [ lxr-Feature Requests-2780730 ] Allow Ident Searches to be Restricted by Filename

[SourceForge.net <no...@so...>]

Feature Requests item #2780730, was opened at 2009-04-24 20:02
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=2780730&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing Interface
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: Nobody/Anonymous (nobody)
Summary: Allow Ident Searches to be Restricted by Filename

Initial Comment:
I.e. just like the general search is (inc. regular expression support). On large code bases you often know you want to restrict the search to a particular layer or component which can normally be achieved by restricting results to files containing, for example, "Bluetooth" or "Persistence" in their path.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-05-01 21:38

Message:
Interesting idea, sounds worth implementing if the performance impact is
not too great for the regexp matching.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=2780730&group_id=27350

[Lxr-dev] [ lxr-Bugs-2783472 ] .htaccess-apache2 doesn't work under Apache2.2

[SourceForge.net <no...@so...>]

Bugs item #2783472, was opened at 2009-04-29 08:23
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2783472&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: v0.9.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: .htaccess-apache2 doesn't work under Apache2.2

Initial Comment:
[Wed Apr 29 10:14:16 2009] [alert] [client x.x.x.x] [snip]/xref/.htaccess: This package can't be used under threaded MPMs at /usr/lib/perl5/ModPerl/RegistryPrefork.pm line 12.\nCompilation failed in require at (eval 2) line 3.\n


~/xref$ /usr/sbin/apache2 -V
Server version: Apache/2.2.8 (Ubuntu)
Server built:   Jun 25 2008 13:50:52
Server's Module Magic Number: 20051115:11
Server loaded:  APR 1.2.11, APR-Util 1.2.12
Compiled using: APR 1.2.11, APR-Util 1.2.12
Architecture:   32-bit
Server MPM:     Worker
  threaded:     yes (fixed thread count)
    forked:     yes (variable process count)
Server compiled with....
 -D APACHE_MPM_DIR="server/mpm/worker"
 -D APR_HAS_SENDFILE
 -D APR_HAS_MMAP
 -D APR_HAVE_IPV6 (IPv4-mapped addresses enabled)
 -D APR_USE_SYSVSEM_SERIALIZE
 -D APR_USE_PTHREAD_SERIALIZE
 -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT
 -D APR_HAS_OTHER_CHILD
 -D AP_HAVE_RELIABLE_PIPED_LOGS
 -D DYNAMIC_MODULE_LIMIT=128
 -D HTTPD_ROOT=""
 -D SUEXEC_BIN="/usr/lib/apache2/suexec"
 -D DEFAULT_PIDLOG="/var/run/apache2.pid"
 -D DEFAULT_SCOREBOARD="logs/apache_runtime_status"
 -D DEFAULT_ERRORLOG="logs/error_log"
 -D AP_TYPES_CONFIG_FILE="/etc/apache2/mime.types"
 -D SERVER_CONFIG_FILE="/etc/apache2/apache2.conf"

mod_perl from:
libapache2-mod-perl2                       2.0.3-2ubuntu2



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2783472&group_id=27350

[Lxr-dev] FW: [Lxr-commits] CVS: lxr/lib/LXR/Index Mysql.pm, 1.24, 1.25 DB.pm, 1.15, 1.16 Postgres.pm, 1.24, 1.25 Oracle.pm, 1.13, 1.14

[Adrian I. <adr...@ho...>]

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

[Lxr-dev] [ lxr-Bugs-2781293 ] Bug 1691407 fix caused perl files to be ignored by genxref

[SourceForge.net <no...@so...>]

Bugs item #2781293, was opened at 2009-04-25 21:20
Message generated for change (Settings changed) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2781293&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: genxref
Group: current cvs
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: AdrianIssott (adrianissott)
Summary: Bug 1691407 fix caused perl files to be ignored by genxref

Initial Comment:
As per summary. It seems the fix caused genxref to think perl files are binary files and hence they weren't indexed. The fix is to delete the section of the magic.mime file that identifies perl files.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2781293&group_id=27350

[Lxr-dev] [ lxr-Bugs-2781293 ] Bug 1691407 fix caused perl files to be ignored by genxref

[SourceForge.net <no...@so...>]

Bugs item #2781293, was opened at 2009-04-25 21:20
Message generated for change (Settings changed) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2781293&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: genxref
Group: current cvs
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: AdrianIssott (adrianissott)
Summary: Bug 1691407 fix caused perl files to be ignored by genxref

Initial Comment:
As per summary. It seems the fix caused genxref to think perl files are binary files and hence they weren't indexed. The fix is to delete the section of the magic.mime file that identifies perl files.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2781293&group_id=27350

[Lxr-dev] [ lxr-Bugs-2781293 ] Bug 1691407 fix caused perl files to be ignored by genxref

[SourceForge.net <no...@so...>]

Bugs item #2781293, was opened at 2009-04-25 21:20
Message generated for change (Tracker Item Submitted) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2781293&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: genxref
Group: current cvs
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: AdrianIssott (adrianissott)
Summary: Bug 1691407 fix caused perl files to be ignored by genxref

Initial Comment:
As per summary. It seems the fix caused genxref to think perl files are binary files and hence they weren't indexed. The fix is to delete the section of the magic.mime file that identifies perl files.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2781293&group_id=27350

[Lxr-dev] [ lxr-Feature Requests-2780730 ] Allow Ident Searches to be Restricted by Filename

[SourceForge.net <no...@so...>]

Feature Requests item #2780730, was opened at 2009-04-24 21:02
Message generated for change (Tracker Item Submitted) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=2780730&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing Interface
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: Nobody/Anonymous (nobody)
Summary: Allow Ident Searches to be Restricted by Filename

Initial Comment:
I.e. just like the general search is (inc. regular expression support). On large code bases you often know you want to restrict the search to a particular layer or component which can normally be achieved by restricting results to files containing, for example, "Bluetooth" or "Persistence" in their path.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=2780730&group_id=27350

[Lxr-dev] [ lxr-Feature Requests-437913 ] Integration with Mozilla

[SourceForge.net <no...@so...>]

Feature Requests item #437913, was opened at 2001-07-02 14:49
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=437913&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing Interface
Group: Bluesky
Status: Open
Priority: 5
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Nobody/Anonymous (nobody)
Summary: Integration with Mozilla

Initial Comment:
I'd really like to use the search sidebar in Mozilla
with the lxr.  This would appear to require writing a
Sherlock script for lxr - see mozilla.org for details.

Even cooler (IMHO) would be to use XUL/CSS/XML to make
a better source interface than HTML allows.  I'm think
of things like:

- Right click an identifier to get a list of the other
members of the class
- show classes/locations in a separate panel
- Show class definitions for selected class

In other words, the browsing/viewing part of a complete
IDE.  Since there are various Mozilla based IDE
projects this could end up being the best ever IDE.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-24 19:59

Message:
This could be integrated with the Bespin project "a Mozilla Labs experiment
that proposes an open, extensible web-based framework for code editing that
aims to increase developer productivity, enable compelling user
experiences, and promote the use of open standards" and create a navigation
view to their editing view of the code. Would be very cool indeed.

See http://labs.mozilla.com/projects/bespin/.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=437913&group_id=27350

[Lxr-dev] [ lxr-Bugs-469413 ] Non-symbols can be mistaken for symbols

[SourceForge.net <no...@so...>]

Bugs item #469413, was opened at 2001-10-09 06:38
Message generated for change (Comment added) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=469413&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: current cvs
Status: Open
Resolution: None
Priority: 3
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: AdrianIssott (adrianissott)
Summary: Non-symbols can be mistaken for symbols

Initial Comment:
When marking up source code, each possible string is
checked to see if it is a symbol, by calling
issymbol().  The implementations in Mysql.pm and
Postgres.pm only use the string to lookup whether this
is a symbol.

Unfortunately it is possible that in one release a
string is a symbol, while in another it is not.  Since
the release of the file being looked at is not taken
into account, the current algorithm will highlight
symbols that, when clicked on, will return "Not used".

The solution is to change issymbol to do:

select s.symid from symbols s, releases r, indexes i
where s.symname = 'name' and i.symid = s.symid and
i.fileid = r.fileid and r.release = 'release';

This is not much slower, and the results could be cached.

Note that is problem shows up only rarely, since it is
unusual to have a string that both resembles an
identifier (not a reserved word, not a string/include
token) but matches a symbol name in another release. 
The easiest way to show it up is to look at the source
of a release that has not be indexed yet.

----------------------------------------------------------------------

>Comment By: AdrianIssott (adrianissott)
Date: 2009-04-22 21:08

Message:
Malcolm, I'm happy to take this on as it was implicitly what I was going to
do anyway :)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=469413&group_id=27350

[Lxr-dev] [ lxr-Bugs-1085321 ] updated Oracle.pm and initdb_oracle.sql

[SourceForge.net <no...@so...>]

Bugs item #1085321, was opened at 2004-12-14 19:08
Message generated for change (Settings changed) made by adrianissott
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1085321&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database interface
Group: v0.9.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: George Cross (gccross)
>Assigned to: AdrianIssott (adrianissott)
Summary: updated Oracle.pm and initdb_oracle.sql

Initial Comment:
I recently installed LXR using an Oracle 8.1.7 database.  

I had to modify the Oracle.pm and initdb_oracle.sql
files to make it work.  Here they have been attached.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1085321&group_id=27350

[Lxr-dev] [ lxr-Feature Requests-2774495 ] Deprecate or Remove Unused LXR::Lang Modules

[SourceForge.net <no...@so...>]

Feature Requests item #2774495, was opened at 2009-04-19 16:55
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=2774495&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
Priority: 5
Private: No
Submitted By: AdrianIssott (adrianissott)
Assigned to: AdrianIssott (adrianissott)
Summary: Deprecate or Remove Unused LXR::Lang Modules

Initial Comment:
The following LXR::Lang modules don't actually get used by default:
* LXR::Lang::Perl (last modified in CVS in Mar 2001)
* LXR::Lang::Python (last modified in CVS in Sept 1999)

Instead LXR::Lang::Generic is used for Perl and Python. Having the above modules present is just confusing and hence should be deprecated or removed.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2009-04-22 16:29

Message:
Modules zapped!

----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2009-04-21 15:40

Message:
I say nuke the Lang modules.

Don't know whether the DB module works or not - I'll give it a test to
see.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-20 20:30

Message:
One other thought - is anyone actually using LXR::Index::DB? I'm not sure
it'll run since it too hasn't been changed in ages.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-20 20:29

Message:
So would you like me to delete them rather than some kind of deprecation? I
must admit I'd prefer to get rid of them entirely since I'd be surprised if
anyone is actually using them.

As for alternatives to using LXR::Lang::Generic, Cobol and Java would be
the only remaining two that are different and both derive from
LXR::Lang::Generic. This would then leave the question of why have both
LXR::Lang and LXR::Lang::Generic but that's a bigger question ...

----------------------------------------------------------------------

Comment By: Malcolm Box (mbox)
Date: 2009-04-20 10:18

Message:
Agreed, they should go.  It is useful to have at least one language module
as an example of how to create one - I think the Cobol one is still used,
so that would serve.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390120&aid=2774495&group_id=27350

[Lxr-dev] [ lxr-Bugs-1691407 ] genxref binary file detection flawed

[SourceForge.net <no...@so...>]

Bugs item #1691407, was opened at 2007-03-30 17:04
Message generated for change (Comment added) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1691407&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: genxref
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 7
Private: No
Submitted By: Paul D. Smith (psmith)
>Assigned to: Malcolm Box (mbox)
Summary: genxref binary file detection flawed

Initial Comment:
Genxref uses File::MMagic to determine what kind of file it's indexing, and that's great.  However, I noticed that a number of binary files in my tree were not being detected properly as "binary".

Looking more closely I see that Perl's File::MMagic module uses an older, less complete table of file types as its hardcoded defaults, which is causing it to not detect some types of non-text files.  However, it turns out that you can tell File:MMagic to use an external definition table for file types rather than the default builtin table.

So, I got the latest version of magic.mime from my Ubuntu system and added it to the LXR directory.  I needed to uncomment one or two lines, which magic.mime had commented out with the note 'Formats for "compress" proper have been moved into "compress.c"', which we don't have in File::MMagic apparently.

This helped a LOT in classifying my files.  It still gets a few wrong, though: apparently its method for detecting binary-ness of files that don't match any of the mime types is more liberal than the file(1) method.  But, this works much better than before (detects .z compressed files, RPMs, etc.)


Patch attached.

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2009-04-22 16:19

Message:
Fixed as described - thanks for the patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=1691407&group_id=27350

[Lxr-dev] [ lxr-Bugs-2778652 ] Filenames with % break

[SourceForge.net <no...@so...>]

Bugs item #2778652, was opened at 2009-04-22 15:27
Message generated for change (Tracker Item Submitted) made by mbox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2778652&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: current cvs
Status: Open
Resolution: None
Priority: 6
Private: No
Submitted By: Malcolm Box (mbox)
Assigned to: Malcolm Box (mbox)
Summary: Filenames with % break

Initial Comment:
Filenames with a % character in them cannot be browsed - the filename is truncated at the % and source reports that the file does not exist.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=2778652&group_id=27350