Re: [Lxde-list] LXTASK SEGFAULT (was [PATCH] fix segfault)

[John S. <mai...@ba...>]

guess i forgot to add the hint that this is about LXTASK

please merge this ASAP and my previous patches as well

i just lost half an hour backporting this to lxtask 0.14 because of the 
whole translation crap that broke my cherry picks and left me with 100 
.po merge errors


On 07/25/2012 11:41 PM, John Spencer wrote:
> On 07/25/2012 11:22 PM, John Spencer wrote:
>> On 07/25/2012 11:16 PM, John Spencer wrote:
>>> when a task was finished between the opening and read of the second
>>> procfile, no error handling was done at all and thus crashed when
>>> strrchr returned NULL, which was incremented by 1 and then dereferenced.
>>>
>>> steps to reproduce:
>>> * launch lxtask
>>> * launch a script that starts a lot of shortliving processes in a loop
>>> * wait for crash
>>>
>>> -- JS
>>
>> oops. forgot to close the filehandle. here's a fixed version
>>
>
> i just noticed there was the same issue (read without checking return
> value) a second time, so i just fixed that as well.
> also i replaced the hardcoded buffer sizes with sizeof.