From: Andrea F. <an...@op...> - 2011-08-16 09:25:39
|
2011/8/16 Martin Bagge / brother <br...@bs...>: > On 2011-08-15 15:50, Julien Lavergne wrote: >> I made some local changes on gpicview, it should build with GTK3, but it's still not working (segfault on loading image). I'll commit it to trunk when I'll be back home. > > I hope I misread you now but if not I want to make it clear. > > Do /NOT/ commit things that are not complete/do not work in the master > branch. Not even if it require a --enable-gtk-3 or whatever for configure. I agree, but at today, gpicview fail to build with "--enable-gtk3", so if those changes solve the build failure, than i believe is mostly welcome. Regards Andrea |