From: <ro...@us...> - 2004-01-05 19:44:23
|
Update of /cvsroot/ltp/ltp/testcases/kernel/syscalls/mallopt In directory sc8-pr-cvs1:/tmp/cvs-serv26201 Modified Files: mallopt01.c Log Message: Applied patch from Erik Andersen: ================================= The (non SuSv3) function mallopt() is tested by ltp. On line 88 of mallopt01.c, the test checks if usmblks happens to equal 0. It just so happens that usmblks is set to 0 in glibc when threading is enabled, but testing if usmblks is set to 0 is meaningless, and produces incorrect results when glibc is built without thread support, and when used with uClibc (which does not force usmblks to 0 when threads are enabled). I recommend removing the pointless and apparently incorrect usmblks test from line 88 of mallopt01.c. ================================= Index: mallopt01.c =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/mallopt/mallopt01.c,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- mallopt01.c 5 Jul 2003 03:15:05 -0000 1.2 +++ mallopt01.c 5 Jan 2004 19:44:20 -0000 1.3 @@ -85,11 +85,6 @@ flag = 1; local_flag = FAILED; }; - if (info.usmblks != 0) { - fprintf(temp, "mallinfo failed: usmblks != 0\n"); - flag = 1; - local_flag = FAILED; - } if (info.smblks != 0) { fprintf(temp, "mallinfo failed: smblks != 0\n"); flag = 1; |