Re: [LTP] Patches for mincore01, shmget02 and capset02

[Robert W. <ro...@us...>]

I applied the patches to the CVS tree for April's release...thanks Gernot!

-Robbie
(Embedded image moved to file: pic18973.jpg)


                                                                           
             Gernot Payer                                                  
             <gp...@su...>                                              
             Sent by:                                                   To 
             ltp-list-admin@li         ltp...@li...      
             sts.sourceforge.n                                          cc 
             et                                                            
                                                                   Subject 
                                       [LTP] Patches for mincore01,        
             03/16/2005 06:01          shmget02 and capset02               
             AM                                                            
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Hi all,

in recent runs I experienced unexpected failures with these testcases and
found out that subtestcases in these programs have some bugs.

mincore01
---------

One test case tests, whether with parameter length < 0 EINVAL is returned.
However this parameter has type size_t, which is unsigned.
The kernel only returns EINVAL if start + length < start (overflow).
Otherwise
this syscall will return ENOMEM (unmapped virtual memory in
[start,start+length) ) or might even succeed.
Because of this uncertainty, I dropped this subtestcase.

shmget02
--------

One sub test case tests what happens, if a nonexisting key is used without
flag IPC_CREAT. In this testcase it is assumed that -1 is never used as a
key. However -1 is a perfectly legal key, so it might exist.
My patch tests for a nonexisting key, which can be used in this test case.

capset02
--------

Subtestcase 4 assumes that capset cannot be used at all by a normal
process,
because capability CAP_SETPCAP is missing. However with current 2.6.x
kernels
a root process can set all capabilities it already owns to itself (i.e.
everything except SET_PCAP).
My patch now changes two things:
             - a child process is created which does nothing else than
sleeping
             - subtestcase 4 uses capset on the child process


mfg
Gernot
(See attached file: fix-capset02.patch)(See attached file:
fix-mincore01.patch)(See attached file: fix-shmget02.patch)