[LTP] creat07: testcases/bin/test1 might be zeroed after a failure

[Jin, G. <gor...@in...>]

=20
In creat07.c, if following wrong condition (i.e. creat succeeded) =
happens, the file (testcases/bin/test1) will be truncated to length 0. =
This results later runs always getting FAIL at execve(fname, NULL, =
NULL).

			TEST(creat(fname, O_WRONLY));

			if (TEST_RETURN !=3D -1) {
				retval=3D1;
				tst_resm(TFAIL, "creat(2) succeeded on "
					 "expected fail");
				continue;
			}

We shouldn't count on testers realizing they need manually =
backup/restore the test file when this condition happens. So I suggest =
the test case backup/restore fname automatically.

Regards,
Gordon

-----Original Message-----
From: ltp...@li... =
[mailto:ltp...@li...] On Behalf Of Paul Larson
Sent: Thursday, August 12, 2004 11:11 PM
To: ltp...@li...
Subject: [LTP] Phasing out runalltests.sh

The main script for kicking off LTP has the unfortunate name of
"runalltests.sh" when in all actuality it only runs about a third of the
tests available in LTP (due to various system setup, automation, and
destructiveness issues, some can't or shouldn't be run automatically by
default).  This has caused some confusion in the past for many people.

What I'd like to do, for now, is simply rename runalltests.sh to
something like "runltp" and create a temporary runalltests.sh to replace
it.  The new runalltests.sh would bring up a warning, pause for a short
while, thump the user in the head, etc. to tell them that it's going
away and any scripts that call runalltests.sh should be changed.

Would this cause a serious problem for anyone?  Any better suggestions
for a name?  How long does everyone feel it would be appropriate to
leave the runalltests.sh stub?  Finally, while we're going about
breaking things, are there any other changes people would like to see
right now to the main runltp script?

Thanks,
Paul Larson