Re: [LTP] Simple pan bug

[Robert W. <ro...@us...>]

Thanks for the patch Brian!  I applied it to our CVS tree for inclusion in
next month's release.

-Robbie

(Embedded image moved to file: pic20195.jpg)


                                                                           
             Brian Reitz                                                   
             <bd...@ca...>                                             
             Sent by:                                                   To 
             ltp-list-admin@li         ltp...@li...      
             sts.sourceforge.n                                          cc 
             et                                                            
                                                                   Subject 
                                       [LTP] Simple pan bug                
             07/15/2004 01:47                                              
             PM                                                            
                                                                           
                                                                           
                                                                           
                                                                           





I've got a patch to pan.c that fixes up a format problem.  There are a
few test tag names that are greater than 20 characters.  Yet the fprintf
at line 708 in pan/pan.c only prints out the name string to a max of 20
chars:

                        {
                                        if (w != 0)
                                                ++*failcnt;
                                        fprintf(logfile, "%-30.20s
%-10.10s %-5d\n",

running[i].cmd->name, ((w != 0) ? "FAIL" : "PASS"),
                                                        w);
                        }



The result of this is the human readable output generates non unique
entries for the following tests:

sched_get_priority_max01
sched_get_priority_max02
sched_get_priority_min01
sched_get_priority_min02

sched_rr_get_interval01
sched_rr_get_interval02
sched_rr_get_interval03

These tests show up as follows:


sched_get_priority_m           PASS       0
sched_get_priority_m           PASS       0
sched_get_priority_m           PASS       0
sched_get_priority_m           PASS       0

sched_rr_get_interva           PASS       0
sched_rr_get_interva           PASS       0
sched_rr_get_interva           PASS       0


I'm attaching a simple patch that fixes this issue.  My apologies if
this is the wrong list to post these sort of issues to.  If it is easy
to make these changes (create a bug, submit a fix) myself I'm willing to
do it if somebody can help me understand the steps I need to take.

I don't subscribe to the ltp-list so anything you post to that list that
you want me to reply to will require a copy sent to me directly (sorry).

Thanks,
Brian Reitz

--- pan/pan.c            Mon Dec  1 12:34:18 2003
+++ /mnt/ultest/ltp.new/pan/pan.c          Thu Jul 15 13:13:25 2004
@@ -705,7 +705,7 @@
                                     {
                                                             if (w != 0)

++*failcnt;
-
fprintf(logfile, "%-30.20s %-10.10s %-5d\n",
+
fprintf(logfile, "%-30.30s %-10.10s %-5d\n",

       running[i].cmd->name, ((w != 0) ? "FAIL" : "PASS"),

       w);
                                     }