[LTP] Re: [Ltp-cvs] ltp/lib rmobj.c,1.2,1.3

[Nathan S. <ns...@sg...>]

On Fri, Jul 25, 2003 at 09:16:49AM -0700, ro...@us... wrote:
> Update of /cvsroot/ltp/ltp/lib
> In directory sc8-pr-cvs1:/tmp/cvs-serv16893
> 
> Modified Files:
> 	rmobj.c 
> Log Message:
> Applied patch from Ramesh Subramanian:
> ==================
> This is an annoyance where the rmdir() call fails due to the
> directory not being empty. I just replaced the rmdir with a system("rm -rf")
> construct as a quick fix.
> ==================

I really don't like the idea of this patch.  Under what conditions is
rmobj() failing to remove the entries in a directory prior to calling
rmdir()?  I want to see a test case here.  Adding an "rm -rf" is
irresponsible.  

-- 
Nate Straz                                              ns...@sg...
sgi, inc                                           http://www.sgi.com/
Linux Test Project                                  http://ltp.sf.net/