Re: [LTP] Fix ltpapcmd

[Paul L. <pl...@li...>]

On Fri, 2003-03-14 at 03:49, Andreas Jaeger wrote:
>=20
> ltpapcmd was broken due to missing includes.  After fixing these
> warnings with the appended patch:
Not an issue on any of the archs or distros I've tested this on.=20
=20
> ltpapicmd.c:151: warning: return type defaults to `int'
> ltpapicmd.c: In function `main':
> ltpapicmd.c:189: warning: implicit declaration of function `basename'
> ltpapicmd.c:189: warning: cast to pointer from integer of different size
Mind if I ask what you are running this on?

> I would really urge all developers to not ignore the warnings and fix
> them.  A testsuite that runs out of the box and doesn't need hundreds
> of patches before trusting that it works is much more usable and will
> therefore be used by developers.  But I'm quite disappointed by the
> current state of the code - especially since some months ago all open
> problems were fixed. :-(
The compiles cleanly with no warnings or errors on every machine I
tested it on, but I'm well aware that I don't have everything out there!
:)  I suspect that most developers do make an effort to clean up
warnings when they see them.

-Paul Larson