Re: [LTP] Question about PAGE_SIZE usage in 'fsx-linux.c'...

[Paul L. <pl...@do...>]

Hmm, I don't see any good reason for that difference, but an even better 
question is why is this test being duplicated?  That line is the ONLY 
difference in the two of them, other than the shell scripts in the dirs 
with them.  It's not that it takes up much space, but they still 
shouldn't be duplicated so that if something gets fixed in one copy, we 
don't risk forgetting about the other.  That's most likely what happend 
here.  I'll do away with one of them, but leave the shell scripts alone. 
 Keeping the one that uses getpagesize() of course.

-Paul Larson

Steven J. Hill wrote:

> Why in 'testcases/kernel/fs/fsx-linux/fsx-linux.c' is:
>
>     #define PAGE_SIZE getpagesize()
>
> and in 'testcases/network/nfs/fsx-linux/fsx-linux.c'
>
>     #define PAGE_SIZE 4096
>
> Should they be the same for consistency, or are the tests
> doing something different and subtle from each other?
>
> -Steve
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by: OSDN - Tired of that same old
> cell phone?  Get a new here for FREE!
> https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list