Re: [LTP] [PATCH v2] lib/test_net.sh: add network help script

[<ch...@su...>]

Hi!
> >> +[ -z "$TST_LIB_LOADED" ] && . test.sh
> >> +
> >> +# Run command on remote host.
> >> +# Options:
> >> +# -b run in background
> >> +# -s safe option, if something goes wrong, will exit with TBROK
> >> +# -c specify command to run
> >> +
> >> +tst_rhost_run()
> >> +{
> >> +	# this is needed to run tools/apicmds on remote host
> >> +	local pre_cmd="TCID=$TCID TST_COUNT=1 TST_TOTAL=1"
> > Hmm, if I get it right, this is here in order to make possible to run
> > the tst_get_unused_port apicmd command.
> >
> > I don't like that much that we have to set the TST_COUNT and TST_TOTAL
> > too. Maybe we should relax the rules in ltpapicmd.c, given that
> > TST_TOTAL is not used for anything in the lib/ directory and the
> > tst_count is used only used only in the tst_print().
> Yes, you are right, I did so because of apicmds.
> What about if we remove the check completely?  We won't use tst_res*, 
> tst_brk*... in new tests.

For now I've added an exception for the tst_get_unused_port the same way
we do it for tst_kvercmp. See latest git commit.

-- 
Cyril Hrubis
ch...@su...